Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - support multiple DB types #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature - support multiple DB types #21

wants to merge 4 commits into from

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Nov 6, 2023

This draft seeks to introduce supporting multiple database types out of the box.

It makes the following assumptions/attempts the following:

  • The most basic/default setup is the current one, namely a mariadb-drupal lagoon image (such as uselagoon/mariadb-10.5-drupal)
  • If one wishes to distinguish between a database, we use the DATABASE_TYPE environment variable, which is assumed to be either postgres, mysql, or mariadb
  • Based on these types, we take our best guess at what the defaults for that DATABASE_TYPE is.

@bomoko @tobybellwood
Update assets/settings.lagoon.php
74526fb 
Co-authored-by: Toby Bellwood <toby.bellwood@amazee.io>
@bomoko bomoko marked this pull request as ready for review November 13, 2023 00:44
@bomoko bomoko added this to the v1.0.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bomoko @tobybellwood