Add host_authorization setting for dev environment
#3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
commented
Nov 20, 2024
kevindew
reviewed
Nov 20, 2024
Sinatra 4.1 ships with a breaking change that [enables host allowlisting middleware][1] in local development, which in turn breaks running Search API through GOV.UK Docker. This adds an explicit `permitted_hosts` setting for the middleware in the development environment, which allows access with arbitrary host headers. [1]: sinatra/sinatra#2053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinatra 4.1 ships with a breaking change that enables host allowlisting middleware in local development, which in turn breaks running Search API through GOV.UK Docker.
This adds an explicit
permitted_hostssetting for the middleware in the development environment, which allows access with arbitrary host headers.