Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address accessibility issues raised by Sitemorse report #1113

Merged
merged 16 commits into from
Jan 8, 2025
Merged

Address accessibility issues raised by Sitemorse report #1113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9579980
Combine web, worker and counter into a single container
pixeltrix Nov 21, 2024
a1c4aec
Remove legacy IE code and behaviour
pixeltrix Nov 21, 2024
0d55099
Wrap label in a h2 tag for accessibility
pixeltrix Nov 22, 2024
8ec1793
Use void tags instead of self-closing tags
pixeltrix Nov 22, 2024
f3314ac
Remove unnecessary role attributes
pixeltrix Nov 22, 2024
ba25fd7
Don't use sections without headings
pixeltrix Nov 23, 2024
a53938c
Use darker grey to improve contrast
pixeltrix Nov 23, 2024
c907be8
Fix improperly nested elements
pixeltrix Nov 23, 2024
b421e44
Fix hover colour of pagination chevrons
pixeltrix Nov 23, 2024
03bcefe
Add meta description tag to improve Lighthouse SEO score
pixeltrix Dec 22, 2024
743a67e
Improve the accessibility of links
pixeltrix Dec 22, 2024
1656aef
Ensure header levels are sequential
pixeltrix Dec 23, 2024
4b8dd77
Use dnsmasq for common hostnames inside and outside docker
pixeltrix Dec 23, 2024
b70ed5c
Make additional pages crawlable
pixeltrix Dec 23, 2024
e7fd53d
Allow the app to boot with RAILS_ENV=production
pixeltrix Dec 24, 2024
3abc9ee
Use mocha and lighthouse to add accessibility specs
pixeltrix Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap label in a h2 tag for accessibility
  • Loading branch information
@pixeltrix
pixeltrix committed Jan 8, 2025
commit 0d55099c9c12053055c969bd0087e871c303911f
8 changes: 6 additions & 2 deletions app/assets/stylesheets/petitions/views/_home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,19 @@ a.threshold-panel:hover, a.threshold-panel:focus {
padding-bottom: 0;
}

.search-petitions label {
.search-petitions h2 {
@include bold-36();

display: block;
margin-top: em(30, 20);
margin-bottom: em(10, 20);

@include media(tablet) {
margin-top: em(30, 24);
margin-bottom: em(10, 24);
}

label {
display: block;
margin: 0;
}
}
6 changes: 5 additions & 1 deletion app/views/pages/home/_search_petitions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
<input type="hidden" name="state" value="published">
<% end %>

<%= label_tag 'search', 'Search petitions', id: 'search-petitions-heading' %>
<h2 id="search-petitions-heading">
<%= label_tag 'search' do %>
Search petitions
<% end %>
</h2>

<div class="search-inline">
<%= search_field_tag 'q', nil, class: 'form-control', id: 'search' %>
Expand Down