Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting up the core test suite #84

Merged
merged 14 commits into from
May 8, 2024
Merged

Add support for setting up the core test suite #84

merged 14 commits into from
May 8, 2024

Conversation

renatonascalves
Copy link
Contributor

@renatonascalves renatonascalves commented May 4, 2024 •
edited
Loading

fixes #85

@renatonascalves renatonascalves self-assigned this May 4, 2024
@renatonascalves
Copy link
Contributor Author

renatonascalves commented May 4, 2024 •
edited
Loading

Great! This is working. 🥳 Pending items:

@renatonascalves renatonascalves changed the title WIP: Add support for setting up the core test suite Add support for setting up the core test suite May 6, 2024
renatonascalves
renatonascalves commented May 8, 2024
View reviewed changes
.github/workflows/php-tests.yml
WP_VERSION: ${{ inputs.wordpress }}
WP_DB_HOST: 127.0.0.1
WP_DB_USER: root
WP_DB_PASSWORD: '""'
WP_MULTISITE: ${{ inputs.multisite == true && 1 || 0 }}

PACKAGE_DIRECTORY: ${{ inputs.install-core-tests == true && format('{0}/wp-content/{1}/', '/tmp/wordpress', inputs.working-directory) || inputs.working-directory }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love a second opinion as to why using WP_CORE_DIR or env.WP_CORE_DIR does not work here. It complains the env does not exist. 🤔

Currently, it is hardcoded to '/tmp/wordpress'.

srtfisher
srtfisher approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@srtfisher srtfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me but I am not sure the use case (installing the core test suite) is something we'll use at all at Alley.

@renatonascalves
Copy link
Contributor Author

renatonascalves commented May 8, 2024 •
edited
Loading

@srtfisher Agree! It was necessary for some non-Alley open source projects. If that's not desired, we can certainly remove it.

The repository also contains reusable Github workflows for use on any public repository.

Since it is open source, and can be used in any public repo that might want or need it.

@renatonascalves renatonascalves merged commit c79a0fb into main May 8, 2024
2 checks passed
@renatonascalves renatonascalves deleted the feature/php-tests-core-suite branch May 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtfisher srtfisher srtfisher approved these changes

Assignees

@renatonascalves renatonascalves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP Tests with MySQL Workflow: support setting up core test suite
2 participants
@renatonascalves @srtfisher