Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test notification on failure #4790

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Test notification on failure
  • Loading branch information
michaeldiamant committed Nov 14, 2022
commit 24ca8a1cbf70e0c70c6e10aea9525ed3fec6c397
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ executors:
slack-fail-stop-step: &slack-fail-post-step
post-steps:
- slack/notify:
branch_pattern: "master,rel/beta,rel/nightly,rel/stable"
branch_pattern: "master,rel/beta,rel/nightly,rel/stable,notify_on_failure_test"
event: fail
template: basic_fail_1

Expand Down
2 changes: 1 addition & 1 deletion data/transactions/logic/box.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func opBoxReplace(cx *EvalContext) error {
prev := last - 1 // start
pprev := prev - 1 // name

replacement := cx.stack[last].Bytes
replacement := cx.stack[last].Byte
start := cx.stack[prev].Uint
name := string(cx.stack[pprev].Bytes)

Expand Down