Update systemd-setup.sh to install system.json (#2651)

Right now a system.json file is not created when setting up systemd through the setup-systemd.sh script. Therefore, users aren't letting their nodes know that the algod process will be managed with systemd. This change modifies the systemd configuration file to create the system.json file in the data directory.
algorand · Jul 29, 2021 · 0d4b5bb · 0d4b5bb
1 parent d1425f0
commit 0d4b5bb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/cmd/goal/messages.go b/cmd/goal/messages.go
@@ -75,7 +75,7 @@ const (
 	errorNodeRunning                  = "Node must be stopped before writing APIToken"
 	errorNodeFailGenToken             = "Cannot generate API token: %s"
 	errorNodeCreation                 = "Error during node creation: %v"
-	errorNodeManagedBySystemd         = "This node is managed by systemd, you must run the following command to make your desired state change to your node:\n\nsystemctl %s algorand.service"
+	errorNodeManagedBySystemd         = "This node is using systemd and should be managed with systemctl. For additional information refer to https://developer.algorand.org/docs/run-a-node/setup/install/#installing-algod-as-a-systemd-service"
 	errorKill                         = "Cannot kill node: %s"
 	errorCloningNode                  = "Error cloning the node: %s"
 	infoNodeCloned                    = "Node cloned successfully to: %s"

diff --git a/cmd/goal/node.go b/cmd/goal/node.go
@@ -165,7 +165,7 @@ var startCmd = &cobra.Command{
 		}
 		onDataDirs(func(dataDir string) {
 			if libgoal.AlgorandDaemonSystemdManaged(dataDir) {
-				reportErrorf(errorNodeManagedBySystemd, "start")
+				reportErrorf(errorNodeManagedBySystemd)
 			}
 
 			nc := nodecontrol.MakeNodeController(binDir, dataDir)
@@ -237,7 +237,7 @@ var stopCmd = &cobra.Command{
 		}
 		onDataDirs(func(dataDir string) {
 			if libgoal.AlgorandDaemonSystemdManaged(dataDir) {
-				reportErrorf(errorNodeManagedBySystemd, "stop")
+				reportErrorf(errorNodeManagedBySystemd)
 			}
 
 			nc := nodecontrol.MakeNodeController(binDir, dataDir)
@@ -268,7 +268,7 @@ var restartCmd = &cobra.Command{
 		}
 		onDataDirs(func(dataDir string) {
 			if libgoal.AlgorandDaemonSystemdManaged(dataDir) {
-				reportErrorf(errorNodeManagedBySystemd, "restart")
+				reportErrorf(errorNodeManagedBySystemd)
 			}
 
 			nc := nodecontrol.MakeNodeController(binDir, dataDir)

diff --git a/installer/algorand@.service.template b/installer/algorand@.service.template
@@ -30,6 +30,7 @@ After=network.target
 AssertPathExists=%I
 
 [Service]
+ExecStartPre=bash -c "[[ ! -f %I/system.json ]] && echo '{\"shared_server\":true,\"systemd_managed\":true}' > %I/system.json || :"
 ExecStart=@@BINDIR@@/algod -d %I
 User=@@USER@@
 Group=@@GROUP@@