Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugins): test Algolia Insights plugin #783

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

sarahdayan
Copy link
Member

This adds test coverage for @algolia/autocomplete-plugin-algolia-insights. I'm adding those now to ensure new features don't trigger undetected regressions like the one fixed in #771.

I've covered the plugin API for now. There are still untested methods from the insights wrapper created in createSearchInsightsApi but we don't document them for now so I believe it can be tackled in another PR.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sarahdayan sarahdayan merged commit 6de70d3 into next Oct 21, 2021
@sarahdayan sarahdayan deleted the test/createAlgoliaInsightsPlugin branch October 21, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants