-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from deepinsight:master #46
base: master
Are you sure you want to change the base?
Conversation
c8fcb40
to
13da034
Compare
e391616
to
760d6de
Compare
3c5e7bc
to
fa9afd0
Compare
071e378
to
2a4ea6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (6)
README.md (6)
84-84
: Add hyphens to "state of the art".Consider adding hyphens to "state of the art" for grammatical accuracy.
- InsightFace efficiently implements a rich variety of state of the art algorithms of face recognition, face detection and face alignment, which optimized for both training and deployment. + InsightFace efficiently implements a rich variety of state-of-the-art algorithms of face recognition, face detection and face alignment, which optimized for both training and deployment.Tools
LanguageTool
[uncategorized] ~84-~84: Consider adding hyphens to this phrasal adjective.
Context: ...fficiently implements a rich variety of state of the art algorithms of face recognition, face de...(STATE_OF_THE_ART)
22-22
: Add a comma for clarity.Consider adding a comma after "inswapper_128" for better readability.
- Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service and get help. + Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service, and get help.
26-26
: Correct punctuation and verb tense.Revise the sentence for clarity and grammatical accuracy.
- and move the service to Discord bot, which also support editing on Midjourney generated images, + and moved the service to a Discord bot, which also supports editing on Midjourney-generated images,Tools
LanguageTool
[uncategorized] ~26-~26: Loose punctuation mark.
Context: ...and various backends.2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
105-105
: Correct grammatical error.Change "also interested" to "also be interested".
- You may also interested in some [challenges](https://insightface.ai/challenges) hold by InsightFace. + You may also be interested in some [challenges](https://insightface.ai/challenges) hold by InsightFace.Tools
LanguageTool
[grammar] ~105-~105: Did you mean “be interested”?
Context: ... projects in InsightFace. You may also interested in some [challenges](https://insightfac...(WILL_BASED_ON)
165-165
: Add alt text for images.Adding alt text improves accessibility and SEO.
- <img src="https://insightface.ai/assets/img/github/11513D05.jpg" width="640"/> + <img src="https://insightface.ai/assets/img/github/11513D05.jpg" width="640" alt="Face Detection Example"/>Tools
Markdownlint
165-165: null
Images should have alternate text (alt text)(MD045, no-alt-text)
204-204
: Correct grammatical error.Change "consider to cite" to "consider citing".
- If you find *InsightFace* useful in your research, please consider to cite the following related papers: + If you find *InsightFace* useful in your research, please consider citing the following related papers:Tools
LanguageTool
[grammar] ~204-~204: The verb ‘consider’ is used with the gerund form.
Context: ...htFace* useful in your research, please consider to cite the following related papers: ``` @inp...(ADMIT_ENJOY_VB)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (3 hunks)
Additional context used
LanguageTool
README.md
[uncategorized] ~26-~26: Loose punctuation mark.
Context: ...and various backends.2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~28-~28: Loose punctuation mark.
Context: ...www.picsi.ai) website.2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~29-~29: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~34-~34: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~42-~42: Loose punctuation mark.
Context: ...and various backends.2024-04-17
: [Monocular Identity-Conditioned Facial ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~44-~44: Loose punctuation mark.
Context: ...com/Conferences/2024).2023-08-08
: We released the implementation of [Gene...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~46-~46: Loose punctuation mark.
Context: ...(reconstruction/gaze).2023-05-03
: We have launched the ongoing version of...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~48-~48: Loose punctuation mark.
Context: ...r23-fas-wild#updates).2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...www.picsi.ai) website.2023-02-13
: We launch a large scale in the wild fac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...nges/cvpr23-fas-wild).2022-11-28
: Single line code for facial identity sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~54-~54: Loose punctuation mark.
Context: ...(examples/in_swapper).2022-10-28
: MFR-Ongoing we...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...es if there's any bug.2022-09-22
: Now we have web-demos: [fa...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...insightface.ai:7009/).2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~59-~59: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2022-03-30
: [Partial FC](https://arxiv.org/abs/2203...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~64-~64: Loose punctuation mark.
Context: ...accepted by CVPR-2022.2022-02-23
: SCRFD accepted by [I...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ....cc/Conferences/2022).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ankang Deng, Jia Guo).2021-10-11
: [Leaderboard](https://insightface.ai/mf...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~72-~72: Loose punctuation mark.
Context: .../video/BV15b4y1h79N/).2021-06-05
: We launch a [Masked Face Recognition Ch...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~84-~84: Consider adding hyphens to this phrasal adjective.
Context: ...fficiently implements a rich variety of state of the art algorithms of face recognition, face de...(STATE_OF_THE_ART)
[grammar] ~105-~105: Did you mean “be interested”?
Context: ... projects in InsightFace. You may also interested in some [challenges](https://insightfac...(WILL_BASED_ON)
[typographical] ~126-~126: Two consecutive dots
Context: ...leNet, InceptionResNet_v2, DenseNet, etc.. ### Datasets The training data inclu...(DOUBLE_PUNCTUATION)
[uncategorized] ~178-~178: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...rovide an easy-to-use pipeline to train high efficiency face detectors with NAS supporting. #...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~204-~204: The verb ‘consider’ is used with the gerund form.
Context: ...htFace* useful in your research, please consider to cite the following related papers: ``` @inp...(ADMIT_ENJOY_VB)
Markdownlint
README.md
5-5: null
Images should have alternate text (alt text)(MD045, no-alt-text)
206-206: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
165-165: null
Images should have alternate text (alt text)(MD045, no-alt-text)
186-186: null
Images should have alternate text (alt text)(MD045, no-alt-text)
Additional comments not posted (2)
README.md (2)
12-18
: License section is clear.The license details are well-explained and do not require changes.
36-72
: Changelogs section is well-structured.The changelogs are clear and effectively summarize recent updates.
Tools
LanguageTool
[uncategorized] ~42-~42: Loose punctuation mark.
Context: ...and various backends.2024-04-17
: [Monocular Identity-Conditioned Facial ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~44-~44: Loose punctuation mark.
Context: ...com/Conferences/2024).2023-08-08
: We released the implementation of [Gene...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~46-~46: Loose punctuation mark.
Context: ...(reconstruction/gaze).2023-05-03
: We have launched the ongoing version of...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~48-~48: Loose punctuation mark.
Context: ...r23-fas-wild#updates).2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...www.picsi.ai) website.2023-02-13
: We launch a large scale in the wild fac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...nges/cvpr23-fas-wild).2022-11-28
: Single line code for facial identity sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~54-~54: Loose punctuation mark.
Context: ...(examples/in_swapper).2022-10-28
: MFR-Ongoing we...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...es if there's any bug.2022-09-22
: Now we have web-demos: [fa...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...insightface.ai:7009/).2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~59-~59: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2022-03-30
: [Partial FC](https://arxiv.org/abs/2203...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~64-~64: Loose punctuation mark.
Context: ...accepted by CVPR-2022.2022-02-23
: SCRFD accepted by [I...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ....cc/Conferences/2022).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ankang Deng, Jia Guo).2021-10-11
: [Leaderboard](https://insightface.ai/mf...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~72-~72: Loose punctuation mark.
Context: .../video/BV15b4y1h79N/).2021-06-05
: We launch a [Masked Face Recognition Ch...(UNLIKELY_OPENING_PUNCTUATION)
Update the benchmark for apple devices
updating benchmark
Fix the wrong link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (12)
README.md (12)
4-6
: Add alt text for the image.Adding alt text improves accessibility and SEO.
- <img src="https://insightface.ai/assets/img/custom/logo3.jpg" width="240"/> + <img src="https://insightface.ai/assets/img/custom/logo3.jpg" width="240" alt="InsightFace Logo"/>Tools
Markdownlint
5-5: null
Images should have alternate text (alt text)(MD045, no-alt-text)
20-22
: Add a comma for clarity.Consider adding a comma after "inswapper_128" for better readability.
- Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service and get help. + Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service, and get help.Tools
LanguageTool
[uncategorized] ~22-~22: Possible missing comma found.
Context: ...commercial products and our open-source model inswapper_128. Please visit the [Picsi...(AI_HYDRA_LEO_MISSING_COMMA)
28-30
: Add a hyphen for clarity.Consider adding a hyphen to "Perspective Projection Based" for consistency.
- [Perspective Projection Based Monocular 3D Face Reconstruction Challenge](https://tianchi.aliyun.com/competition/entrance/531961/introduction) + [Perspective Projection-Based Monocular 3D Face Reconstruction Challenge](https://tianchi.aliyun.com/competition/entrance/531961/introduction)Tools
LanguageTool
[uncategorized] ~28-~28: Loose punctuation mark.
Context: ...www.picsi.ai) website.2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~29-~29: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
32-34
: Correct punctuation.Consider revising the punctuation for consistency.
- challenge launched(same with IFRT), + challenge launched (same with IFRT),Tools
LanguageTool
[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~34-~34: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
38-40
: Add a comma for clarity.Consider adding a comma after "inswapper_128" for better readability.
- Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service and get help. + Please visit the [Picsi.Ai](https://www.picsi.ai) website to use the service, and get help.Tools
LanguageTool
[uncategorized] ~38-~38: Possible missing comma found.
Context: ...commercial products and our open-source model inswapper_128. Please visit the [Picsi...(AI_HYDRA_LEO_MISSING_COMMA)
46-46
: Correct punctuation.Consider revising the punctuation for consistency.
- challenge launched(same with IFRT), + challenge launched (same with IFRT),Tools
LanguageTool
[uncategorized] ~46-~46: Loose punctuation mark.
Context: ...(reconstruction/gaze).2023-05-03
: We have launched the ongoing version of...(UNLIKELY_OPENING_PUNCTUATION)
50-52
: Correct punctuation.Consider revising the punctuation for consistency.
- Workshop, see details at [challenges/cvpr23-fas-wild](challenges/cvpr23-fas-wild). + Workshop. See details at [challenges/cvpr23-fas-wild](challenges/cvpr23-fas-wild).Tools
LanguageTool
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...www.picsi.ai) website.2023-02-13
: We launch a large scale in the wild fac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...nges/cvpr23-fas-wild).2022-11-28
: Single line code for facial identity sw...(UNLIKELY_OPENING_PUNCTUATION)
54-56
: Correct punctuation.Consider revising the punctuation for consistency.
- website is refactored, please create issues if there's any bug. + website has been refactored. Please create issues if there's any bug.Tools
LanguageTool
[uncategorized] ~54-~54: Loose punctuation mark.
Context: ...(examples/in_swapper).2022-10-28
: MFR-Ongoing we...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...es if there's any bug.2022-09-22
: Now we have web-demos: [fa...(UNLIKELY_OPENING_PUNCTUATION)
58-60
: Add a hyphen for clarity.Consider adding a hyphen to "Perspective Projection Based" for consistency.
- [Perspective Projection Based Monocular 3D Face Reconstruction Challenge](https://tianchi.aliyun.com/competition/entrance/531961/introduction) + [Perspective Projection-Based Monocular 3D Face Reconstruction Challenge](https://tianchi.aliyun.com/competition/entrance/531961/introduction)Tools
LanguageTool
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...insightface.ai:7009/).2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~59-~59: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
66-68
: Correct punctuation.Consider revising the punctuation for consistency.
- challenge launched(same with IFRT), + challenge launched (same with IFRT),Tools
LanguageTool
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ....cc/Conferences/2022).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
84-84
: Add hyphens to phrasal adjective.Consider adding hyphens to "state of the art" for consistency.
- InsightFace efficiently implements a rich variety of state of the art algorithms of face recognition, face detection and face alignment, which optimized for both training and deployment. + InsightFace efficiently implements a rich variety of state-of-the-art algorithms of face recognition, face detection and face alignment, which optimized for both training and deployment.Tools
LanguageTool
[uncategorized] ~84-~84: Consider adding hyphens to this phrasal adjective.
Context: ...fficiently implements a rich variety of state of the art algorithms of face recognition, face de...(STATE_OF_THE_ART)
126-126
: Remove double punctuation.Remove the extra period for consistency.
- Commonly used network backbones are included in most of the methods, such as IResNet, MobilefaceNet, MobileNet, InceptionResNet_v2, DenseNet, etc.. + Commonly used network backbones are included in most of the methods, such as IResNet, MobilefaceNet, MobileNet, InceptionResNet_v2, DenseNet, etc.Tools
LanguageTool
[typographical] ~126-~126: Two consecutive dots
Context: ...leNet, InceptionResNet_v2, DenseNet, etc.. ### Datasets The training data inclu...(DOUBLE_PUNCTUATION)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (3 hunks)
Additional context used
LanguageTool
README.md
[uncategorized] ~22-~22: Possible missing comma found.
Context: ...commercial products and our open-source model inswapper_128. Please visit the [Picsi...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~26-~26: Loose punctuation mark.
Context: ...and various backends.2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~28-~28: Loose punctuation mark.
Context: ...www.picsi.ai) website.2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~29-~29: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
[uncategorized] ~32-~32: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~34-~34: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~38-~38: Possible missing comma found.
Context: ...commercial products and our open-source model inswapper_128. Please visit the [Picsi...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~42-~42: Loose punctuation mark.
Context: ...and various backends.2024-04-17
: [Monocular Identity-Conditioned Facial ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~44-~44: Loose punctuation mark.
Context: ...com/Conferences/2024).2023-08-08
: We released the implementation of [Gene...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~46-~46: Loose punctuation mark.
Context: ...(reconstruction/gaze).2023-05-03
: We have launched the ongoing version of...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~48-~48: Loose punctuation mark.
Context: ...r23-fas-wild#updates).2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~50-~50: Loose punctuation mark.
Context: ...www.picsi.ai) website.2023-02-13
: We launch a large scale in the wild fac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...nges/cvpr23-fas-wild).2022-11-28
: Single line code for facial identity sw...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~54-~54: Loose punctuation mark.
Context: ...(examples/in_swapper).2022-10-28
: MFR-Ongoing we...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...es if there's any bug.2022-09-22
: Now we have web-demos: [fa...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~58-~58: Loose punctuation mark.
Context: ...insightface.ai:7009/).2022-08-12
: We achieved Rank-1st of [Perspective P...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~59-~59: This expression is usually spelled with a hyphen.
Context: ...: We achieved Rank-1st of [Perspective Projection Based Monocular 3D Face Reconstruction Challe...(BASED_HYPHEN)
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2022-03-30
: [Partial FC](https://arxiv.org/abs/2203...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~64-~64: Loose punctuation mark.
Context: ...accepted by CVPR-2022.2022-02-23
: SCRFD accepted by [I...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~66-~66: Loose punctuation mark.
Context: ....cc/Conferences/2022).2021-11-30
: MFR-Ongoing challenge...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...hallenges/iccv21-mfr).2021-10-29
: We achieved 1st place on the [VISA trac...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ankang Deng, Jia Guo).2021-10-11
: [Leaderboard](https://insightface.ai/mf...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~72-~72: Loose punctuation mark.
Context: .../video/BV15b4y1h79N/).2021-06-05
: We launch a [Masked Face Recognition Ch...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~84-~84: Consider adding hyphens to this phrasal adjective.
Context: ...fficiently implements a rich variety of state of the art algorithms of face recognition, face de...(STATE_OF_THE_ART)
[grammar] ~105-~105: Did you mean “be interested”?
Context: ... projects in InsightFace. You may also interested in some [challenges](https://insightfac...(WILL_BASED_ON)
[typographical] ~126-~126: Two consecutive dots
Context: ...leNet, InceptionResNet_v2, DenseNet, etc.. ### Datasets The training data inclu...(DOUBLE_PUNCTUATION)
[uncategorized] ~131-~131: Possible missing comma found.
Context: ...training data includes, but not limited to the cleaned MS1M, VGG2 and CASIA-Webfac...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~178-~178: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...rovide an easy-to-use pipeline to train high efficiency face detectors with NAS supporting. #...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~199-~199: Possible missing comma found.
Context: ...t of these models is loose cropped face image while the output is the direct landmark...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~204-~204: The verb ‘consider’ is used with the gerund form.
Context: ...htFace* useful in your research, please consider to cite the following related papers: ``` @inp...(ADMIT_ENJOY_VB)
Markdownlint
README.md
5-5: null
Images should have alternate text (alt text)(MD045, no-alt-text)
206-206: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
165-165: null
Images should have alternate text (alt text)(MD045, no-alt-text)
186-186: null
Images should have alternate text (alt text)(MD045, no-alt-text)
Additional comments not posted (11)
README.md (11)
8-10
: LGTM!The introduction is clear and informative.
12-18
: LGTM!The license section is clear and informative.
24-24
: LGTM!The top news section is clear and informative.
36-36
: LGTM!The changelogs section is clear and informative.
42-42
: LGTM!The changelogs section is clear and informative.
Tools
LanguageTool
[uncategorized] ~42-~42: Loose punctuation mark.
Context: ...and various backends.2024-04-17
: [Monocular Identity-Conditioned Facial ...(UNLIKELY_OPENING_PUNCTUATION)
44-44
: LGTM!The changelogs section is clear and informative.
Tools
LanguageTool
[uncategorized] ~44-~44: Loose punctuation mark.
Context: ...com/Conferences/2024).2023-08-08
: We released the implementation of [Gene...(UNLIKELY_OPENING_PUNCTUATION)
62-64
: LGTM!The changelogs section is clear and informative.
Tools
LanguageTool
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...(reconstruction/jmlr).2022-03-30
: [Partial FC](https://arxiv.org/abs/2203...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~64-~64: Loose punctuation mark.
Context: ...accepted by CVPR-2022.2022-02-23
: SCRFD accepted by [I...(UNLIKELY_OPENING_PUNCTUATION)
70-70
: LGTM!The changelogs section is clear and informative.
Tools
LanguageTool
[uncategorized] ~70-~70: Loose punctuation mark.
Context: ...ankang Deng, Jia Guo).2021-10-11
: [Leaderboard](https://insightface.ai/mf...(UNLIKELY_OPENING_PUNCTUATION)
72-72
: LGTM!The changelogs section is clear and informative.
Tools
LanguageTool
[uncategorized] ~72-~72: Loose punctuation mark.
Context: .../video/BV15b4y1h79N/).2021-06-05
: We launch a [Masked Face Recognition Ch...(UNLIKELY_OPENING_PUNCTUATION)
131-131
: Add a comma for clarity.Consider adding a comma after "but not limited to" for better readability.
- The training data includes, but not limited to the cleaned MS1M, VGG2 and CASIA-Webface datasets, + The training data includes, but is not limited to <details> <summary>Tools</summary> <details> <summary>LanguageTool</summary><blockquote> [uncategorized] ~131-~131: Possible missing comma found. Context: ...training data includes, but not limited to the cleaned MS1M, VGG2 and CASIA-Webfac... (AI_HYDRA_LEO_MISSING_COMMA) </blockquote></details> </details> --- `105-105`: **Correct grammatical error.** Change "also interested" to "also be interested". ```diff - You may also interested in some [challenges](https://insightface.ai/challenges) hold by InsightFace. + You may also be interested in some [challenges](https://insightface.ai/challenges) hold by InsightFace.Likely invalid or redundant comment.
Tools
LanguageTool
[grammar] ~105-~105: Did you mean “be interested”?
Context: ... projects in InsightFace. You may also interested in some [challenges](https://insightfac...(WILL_BASED_ON)
[InsightFace](https://insightface.ai) is an open source 2D&3D deep face analysis toolbox, mainly based on PyTorch and MXNet. | ||
|
||
All face images are aligned by ficial five landmarks and cropped to 112x112: | ||
Please check our [website](https://insightface.ai) for detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct grammatical number.
Consider changing "detail" to "details" for grammatical accuracy.
- Please check our [website](https://insightface.ai) for detail.
+ Please check our [website](https://insightface.ai) for details.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[InsightFace](https://insightface.ai) is an open source 2D&3D deep face analysis toolbox, mainly based on PyTorch and MXNet. | |
All face images are aligned by ficial five landmarks and cropped to 112x112: | |
Please check our [website](https://insightface.ai) for detail. | |
[InsightFace](https://insightface.ai) is an open source 2D&3D deep face analysis toolbox, mainly based on PyTorch and MXNet. | |
Please check our [website](https://insightface.ai) for details. |
|
||
**`2020-04-27`**: InsightFace pretrained models and MS1M-Arcface are now specified as the only external training dataset, for iQIYI iCartoonFace challenge, see detail [here](http://challenge.ai.iqiyi.com/detail?raceId=5def71b4e9fcf68aef76a75e). | ||
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and move the service to Discord bot, which also support editing on Midjourney generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct grammatical errors.
Change "move" to "moved" and "support" to "supports".
- and move the service to Discord bot, which also support editing on Midjourney generated images,
+ and moved the service to a Discord bot, which also supports editing on Midjourney-generated images,
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and move the service to Discord bot, which also support editing on Midjourney generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. | |
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and moved the service to a Discord bot, which also supports editing on Midjourney-generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. |
Tools
LanguageTool
[uncategorized] ~26-~26: Loose punctuation mark.
Context: ...and various backends.2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
|
||
**`2018.10.28`**: Light-weight attribute model [Gender-Age](https://github.com/deepinsight/insightface/tree/master/gender-age). About 1MB, 10ms on single CPU core. Gender accuracy 96% on validation set and 4.1 age MAE. | ||
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and move the service to Discord bot, which also support editing on Midjourney generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct grammatical errors.
Change "move" to "moved" and "support" to "supports".
- and move the service to Discord bot, which also support editing on Midjourney generated images,
+ and moved the service to a Discord bot, which also supports editing on Midjourney-generated images,
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and move the service to Discord bot, which also support editing on Midjourney generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. | |
**`2023-04-01`**: We integrated our most advanced face-swapping models: **inswapper\_cyn** and **inswapper\_dax** and moved the service to a Discord bot, which also supports editing on Midjourney-generated images, see detail at [web-demos/swapping_discord](web-demos/swapping_discord) and our [Picsi.Ai](https://www.picsi.ai) website. |
Tools
LanguageTool
[uncategorized] ~48-~48: Loose punctuation mark.
Context: ...r23-fas-wild#updates).2023-04-01
: We integrated our most advanced face-sw...(UNLIKELY_OPENING_PUNCTUATION)
Update feature_hub.cpp, fix empty check
Clean up unnecessary code
Update InspireFace to 1.1.7
Added the system resource management and monitoring functions
I believe that the `metric` is an important param that people want to control.
rename param name.
Fixed failed db file creation under Python-Native
add library config Signed-off-by: Samuel Herman <sherman8915@gmail.com>
fix creation of C++ sample and add library config for makefiles
Update face_analysis.py
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )