tighten up url generation

alan603 · Mar 3, 2020 · 44a9fb9 · 44a9fb9
1 parent 00d60ff
commit 44a9fb9
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/app/test/helpers/github-repo-builder.ts b/app/test/helpers/github-repo-builder.ts
@@ -40,6 +40,9 @@ export function gitHubRepoFixture({
   endpoint,
   isPrivate,
 }: IGitHubRepoFixtureOptions): GitHubRepository {
+  const htmlUrl = `${
+    endpoint !== undefined ? endpoint : 'https://github.com'
+  }/${owner}/${name}`
   return new GitHubRepository(
     name,
     new Owner(
@@ -49,13 +52,9 @@ export function gitHubRepoFixture({
     ),
     id_counter++,
     isPrivate !== undefined ? isPrivate : null,
-    endpoint !== undefined
-      ? `${endpoint}/${owner}/${name}`
-      : `https://github.com/${owner}/${name}`,
+    htmlUrl,
     defaultBranch || 'master',
-    endpoint !== undefined
-      ? `${endpoint}/${owner}/${name}.git`
-      : `https://github.com/${owner}/${name}.git`,
+    `${htmlUrl}.git`,
     null,
     parent
   )