Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button group): add valueChange output #2722

Merged
merged 10 commits into from
Jun 15, 2021
Merged

feat(button group): add valueChange output #2722

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5aafa87
feat(buttonGroup): add valueChange output
Apr 27, 2021
4b50c51
Merge branch 'master' into feat/button-group-value-change
yggg May 14, 2021
ae6fc23
Merge branch 'master' into feat/button-group-value-change
yggg Jun 15, 2021
4bde68b
docs(button group): rephrase docs on `valueChange`
yggg Jun 15, 2021
f54975d
docs(button toggle): rephrase value input comment
yggg Jun 15, 2021
578d817
refactor(button group): filter out buttons without value
yggg Jun 15, 2021
93f12d3
test(button group): simplify binding
yggg Jun 15, 2021
e69c76e
fix(button group): emit valueChange if buttons pressed initially
yggg Jun 15, 2021
d4f10fb
feat(button group): prevent multiple emissions of empty value
yggg Jun 15, 2021
29cf539
refactor(button group): update value change example
yggg Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(button group): filter out buttons without value
  • Loading branch information
@yggg
yggg committed Jun 15, 2021
commit 578d81758f3b2624f58f2ba04366cce5a34e2137
8 changes: 6 additions & 2 deletions src/framework/theme/components/button-group/button-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ export class NbButtonGroupComponent implements OnChanges, AfterContentInit {
});
}

private emitCurrentValue(toggleButtons: NbButtonToggleDirective[]): void {
this.valueChange.emit(toggleButtons.filter(btn => btn.pressed).map(btn => btn.value));
protected emitCurrentValue(toggleButtons: NbButtonToggleDirective[]): void {
const pressedToggleValues = toggleButtons
.filter((b: NbButtonToggleDirective) => b.pressed && typeof b.value !== 'undefined')
.map((b: NbButtonToggleDirective) => b.value);

this.valueChange.emit(pressedToggleValues);
}
}