Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nbWindowFactory throws on server #1165

Open
1 task done
yggg opened this issue Jan 17, 2019 · 0 comments
Open
1 task done

nbWindowFactory throws on server #1165

yggg opened this issue Jan 17, 2019 · 0 comments
Assignees
@yggg
Labels
bug module:theme module:universal P3: minor

Comments

@yggg
Copy link
Contributor

yggg commented Jan 17, 2019

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • [] feature request

Issue description

Current behavior:
nbWindowFactory throws on server

Expected behavior:
nbWindowFactory should check if window exists with typeof.
Probably return undefined on the server and make NB_WINDOW optional in components which need it.

Steps to reproduce:

Related code:

nebular/src/framework/theme/theme.module.ts

Line 33 in 67c5718

export function nbWindowFactory() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yggg yggg

Labels
bug module:theme module:universal P3: minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nnixaa @yggg