From 1083b35ef9733b2335bd88d587cb282e180267c4 Mon Sep 17 00:00:00 2001
From: Vincent Moens <vmoens@meta.com>
Date: Thu, 27 Jun 2024 16:44:18 +0100
Subject: [PATCH] [Quality] Warn if the sampler is not prioritized but
 update_priority is called (#2253)

---
 torchrl/data/replay_buffers/samplers.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/torchrl/data/replay_buffers/samplers.py b/torchrl/data/replay_buffers/samplers.py
index 520d9e4eec3..8d594fc91a3 100644
--- a/torchrl/data/replay_buffers/samplers.py
+++ b/torchrl/data/replay_buffers/samplers.py
@@ -63,6 +63,9 @@ def update_priority(
         *,
         storage: Storage | None = None,
     ) -> dict | None:
+        warnings.warn(
+            f"Calling update_priority() on a sampler {type(self).__name__} that is not prioritized. Make sure this is the indented behaviour."
+        )
         return
 
     def mark_update(