Skip to content
This repository has been archived by the owner on May 23, 2021. It is now read-only.

Please check before adding modules to the repository #190

Open
WinterSilence opened this issue Apr 4, 2014 · 4 comments
Open

Please check before adding modules to the repository #190

WinterSilence opened this issue Apr 4, 2014 · 4 comments

Comments

@WinterSilence
Copy link
Contributor

Most of the new modules do not meet the standards Kohana, low quality code, not contain comments, for example: all modules by madeinnordeste, /mgalang/kohana-elasticsearch.

fix for madeinnordeste/kohana-net

Please add only "serious" modules, because the repository used junior programmers.

@seyfer
Copy link
Contributor

seyfer commented Jan 21, 2015

Also i think devs need better manual for adding modules in wiki or readme or on site.

When I fork repo I should only edit .gitmodules or also use command like
git submodule update

?
It's not clear.

@ahutchings
Copy link
Owner

Please add only "serious" modules, because the repository used junior programmers.

I don't want to exclude modules based on a subjective assessment of code quality. I would be open to some sort of automated analysis to confirm that a module is compatible with a certain version of Kohana, however.

Also i think devs need better manual for adding modules in wiki or readme or on site.

I agree that kohana-modules.com needs better documentation regarding how to submit a module. I usually run git submodule add https://github.com/kohana/auth.git, for example, if I wanted to add the auth module to a branch. Here's the page that should be edited if anyone wants to submit a pull request:

Add a Module (Source in GitHub)

I'm closing this issue, but I'm open to a pull request for improving the "Add a Module" page.

@seyfer
Copy link
Contributor

seyfer commented Jan 29, 2015

If you close this issue - no one can see the existed problem and the problem gonna became forgotten..

@ahutchings
Copy link
Owner

That's fair, reopening until the documentation issue is resolved.

@ahutchings ahutchings reopened this Jan 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants