Updates for the latest k8s and etcd #17

tas50 · 2017-09-05T21:09:45Z

Update things for the latest and greatest

We have a doc++ formatter built in now that provides nice output Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

Chef has apt_update and apt_repository built in now Signed-off-by: Tim Smith <tsmith@chef.io>

This isn't required with Chef 12 Signed-off-by: Tim Smith <tsmith@chef.io>

The etcd cookbook has been updated to use etcd 3 now Signed-off-by: Tim Smith <tsmith@chef.io>

They've changed all their repos Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

12.5 and 12.6 has some pretty serious custom resource defects that trip up a lot of users. 12.7 came quite a while ago Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

This allows the user who wants to download from the standard sources to just specify the version. Otherwise they can specify their own asset download URL Signed-off-by: Tim Smith <tsmith@chef.io>

It comes for free with Debian Signed-off-by: Tim Smith <tsmith@chef.io>

This is nil by default already Signed-off-by: Tim Smith <tsmith@chef.io>

This requires Chef 12.11, but does a much better job of handling systemd_unit files including validation of the files before usage. It's a much more robust way to handle systemd_unit files vs. executing the reload of the files using a template/notifier/execute chain. Signed-off-by: Tim Smith <tsmith@chef.io>

aespinosa · 2017-09-06T01:20:35Z

Can you show the diff for commandline options for each component (v1.4.5 to v1.7.5). Kubernetes changes the commandline flags quite frequently. At least the default properties should by in-sync with the version offered.

Signed-off-by: Tim Smith <tsmith@chef.io>

This matches the project systemd units Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

It's the default and we're only setting it in this one unit Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 · 2017-09-06T03:27:09Z

Just a heads up this entire thing is broken at the moment. I just wanted to open the PR to get some visibility on what I was working on. Feedback would be super welcome.

Now that I have things matching the upstream unit files a bit more and using the systemd_unit resource I'm going to look at the default options. I'm sure there's quite a few new ones and that will need to get updated to work with 1.7.5 w/o the need for a wrapper cookbook defining new properties.

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 · 2017-09-21T22:22:35Z

@aespinosa This works on Ubuntu. Debian has some cgroups issues that are going to need some additional work, but were broken already.

  Service kube-apiserver
     ✔  should be installed
     ✔  should be running
  Port 8080
     ✔  should be listening
     ✔  processes should include "kube-apiserver"
  Port 6443
     ✔  should be listening
     ✔  processes should include "kube-apiserver"
  Service kube-controller-manager
     ✔  should be installed
     ✔  should be running
  Service kube-proxy
     ✔  should be installed
     ✔  should be running
  Service kube-scheduler
     ✔  should be installed
     ✔  should be running
  Service kubelet
     ✔  should be installed
     ✔  should be running
  Port 10250
     ✔  should be listening
     ✔  processes should include "kubelet"
  Command kubectl
     ✔  get node exit_status should eq 0
     ✔  get node stdout should match /default.*Ready/
  Command kubectl
     ✔  get pod busybox exit_status should eq 0
     ✔  get pod busybox stdout should match /busybox.*Running/

tas50 · 2017-09-21T22:30:33Z

So here's a highlight of the changes:

Use systemd_unit to manage the systemd unit files and sync the unit files with upstream a bit
Add a new property for the file ulimit for each service
Add a new property for specifying the version of each service so you don't have to set the whole artifact URL to use a new version
Default to k8s 1.7.6
Install the dependent packages for kubelets
Require the master property to be set so services will properly start
Use the new etcd cookbook that uses etcd 3.X
Resolve all Chef 14 deprecation warnings and cookstyle warnings
Test on Ubuntu as add ubuntu as a supported platform in the metadata
Remove the usage of the apt cookbook in testing
Use chef-apt-docker instead of manually setting up the repo in testing
Test with docker 17.06.1

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 · 2017-09-22T00:07:15Z

RHEL 7 converges locally now

aespinosa

Thanks for testing the other platforms.

I'll pull in the changes modifying some bits. I personally like multi-line markdown so I'll edit that out.

aespinosa · 2017-09-22T02:21:13Z

libraries/command_generator.rb

@@ -22,7 +22,7 @@ def generate
    def non_commandline_property?(property)
      [
        :name, :run_user, :remote, :checksum,
-        :container_runtime_service
+        :container_runtime_service, :file_ulimit


:version needs to be added too

aespinosa · 2017-09-22T02:25:37Z

libraries/kubelet.rb

+
+      pkgs = case node['platform_family']
+             when 'debian'
+               %w(iptables iproute2 socat util-linux mount ebtables)


I think ethtool is still needed since kubernetes/kubernetes#26093 is still open and kubernetes/kubernetes#30356 was never merged.

Signed-off-by: Tim Smith <tsmith@chef.io>

aespinosa · 2017-09-23T04:13:16Z

Released in 3.0.0 https://supermarket.chef.io/cookbooks/kube/versions/3.0.0

tas50 · 2017-09-23T06:02:32Z

Thanks. I'll have a flannel PR for you soon-ish

tas50 added 14 commits September 5, 2017 11:09

Remove the doc formatter in InSpec

b22631b

We have a doc++ formatter built in now that provides nice output Signed-off-by: Tim Smith <tsmith@chef.io>

Remove redundant omnibus config in kitchen

5c41686

Signed-off-by: Tim Smith <tsmith@chef.io>

Use the Bento version slugs in Kitchen

9f4286e

Signed-off-by: Tim Smith <tsmith@chef.io>

Note that this uses Cookstyle in the Testing doc

c66bc73

Signed-off-by: Tim Smith <tsmith@chef.io>

Remove need for apt in test cookbook

62aff37

Chef has apt_update and apt_repository built in now Signed-off-by: Tim Smith <tsmith@chef.io>

Move the test templates out of default

a4b413d

This isn't required with Chef 12 Signed-off-by: Tim Smith <tsmith@chef.io>

Installed etcd 3.0

c2e4b4f

The etcd cookbook has been updated to use etcd 3 now Signed-off-by: Tim Smith <tsmith@chef.io>

use chef-apt-docker to setup the latest docker repos

21b3771

They've changed all their repos Signed-off-by: Tim Smith <tsmith@chef.io>

Setup the latest docker

34b505c

Signed-off-by: Tim Smith <tsmith@chef.io>

Resolve Chef 14 deprecation warnings

8dd0372

Signed-off-by: Tim Smith <tsmith@chef.io>

Switch to the new client port for etcd

6ec980e

Signed-off-by: Tim Smith <tsmith@chef.io>

Ignore the Policyfile lock file

0069360

Signed-off-by: Tim Smith <tsmith@chef.io>

Require modern version of the test deps

cd7c5d8

Signed-off-by: Tim Smith <tsmith@chef.io>

Bump default to k8s 1.7.5

7ad2c14

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 changed the title ~~Updates for the latest k8s and etcd~~ WIP: Updates for the latest k8s and etcd Sep 5, 2017

tas50 added 6 commits September 5, 2017 15:10

Require Chef 12.7+

86715f1

12.5 and 12.6 has some pretty serious custom resource defects that trip up a lot of users. 12.7 came quite a while ago Signed-off-by: Tim Smith <tsmith@chef.io>

Add a currently unused resource for specifying the version

200db9e

Signed-off-by: Tim Smith <tsmith@chef.io>

Lazily evaluate the default download URL based on version

041e20d

This allows the user who wants to download from the standard sources to just specify the version. Otherwise they can specify their own asset download URL Signed-off-by: Tim Smith <tsmith@chef.io>

Add support for Ubuntu

e84d97d

It comes for free with Debian Signed-off-by: Tim Smith <tsmith@chef.io>

Remove unnecessary nil default

18f9fff

This is nil by default already Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 added 6 commits September 5, 2017 18:24

Restart all services on failure

a5d9a99

Signed-off-by: Tim Smith <tsmith@chef.io>

Add property to manage ulimits of kube services

8179472

This matches the project systemd units Signed-off-by: Tim Smith <tsmith@chef.io>

Use upstream descriptions for the systemd unit files

a405bdb

Signed-off-by: Tim Smith <tsmith@chef.io>

No need to set service type of simple

7316d46

It's the default and we're only setting it in this one unit Signed-off-by: Tim Smith <tsmith@chef.io>

Document the new properties

bba9f95

Signed-off-by: Tim Smith <tsmith@chef.io>

Proper syntax highlighting

81df504

Signed-off-by: Tim Smith <tsmith@chef.io>

Use the latest kubectl in testing

1507e3e

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 added 12 commits September 20, 2017 16:41

Update apiserver, proxy, and scheduler for k8s 1.7

0d92967

Signed-off-by: Tim Smith <tsmith@chef.io>

Match the official package systemd a bit better in kubelet

4af9842

Signed-off-by: Tim Smith <tsmith@chef.io>

Install all the packages that the official kubelet package deps on

76ed46e

Signed-off-by: Tim Smith <tsmith@chef.io>

Remove eth-tool from test now that we handle it in the resource

a37213d

Signed-off-by: Tim Smith <tsmith@chef.io>

Update properties for kubelet

169d906

Signed-off-by: Tim Smith <tsmith@chef.io>

Use k8s 1.7.6

8607daa

Signed-off-by: Tim Smith <tsmith@chef.io>

Exclude ulimit from the CLI options

8f6a51f

Signed-off-by: Tim Smith <tsmith@chef.io>

Update the properties for controller manager for 1.7

b6c5f73

Signed-off-by: Tim Smith <tsmith@chef.io>

Make sure to specify master's port in kube-proxy testing

7af9268

Signed-off-by: Tim Smith <tsmith@chef.io>

scheduler and controller-manager also need master

5578a66

Signed-off-by: Tim Smith <tsmith@chef.io>

Fix the Ubuntu 16.04 bento name

b2bbfe7

Signed-off-by: Tim Smith <tsmith@chef.io>

Show the version of the k8s services we're downloading

42ad68d

Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 changed the title ~~WIP: Updates for the latest k8s and etcd~~ Updates for the latest k8s and etcd Sep 21, 2017

tas50 added 3 commits September 21, 2017 15:31

Update chef requirement in the metadata to match the readme

611ebc5

Signed-off-by: Tim Smith <tsmith@chef.io>

Add RHEL support

22e4a50

Signed-off-by: Tim Smith <tsmith@chef.io>

Add master property to the readme examples

840c33c

Signed-off-by: Tim Smith <tsmith@chef.io>

aespinosa reviewed Sep 22, 2017

View reviewed changes

tas50 added 2 commits September 21, 2017 20:32

Exclude :version property from cli options

f3e8beb

Signed-off-by: Tim Smith <tsmith@chef.io>

Add ethtool package installation on the kubelets

e13f078

Signed-off-by: Tim Smith <tsmith@chef.io>

aespinosa merged commit e13f078 into aespinosa:master Sep 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for the latest k8s and etcd #17

Updates for the latest k8s and etcd #17

tas50 commented Sep 5, 2017

aespinosa commented Sep 6, 2017

tas50 commented Sep 6, 2017

tas50 commented Sep 21, 2017

tas50 commented Sep 21, 2017

tas50 commented Sep 22, 2017

aespinosa left a comment

aespinosa Sep 22, 2017

aespinosa Sep 22, 2017

aespinosa commented Sep 23, 2017

tas50 commented Sep 23, 2017

Updates for the latest k8s and etcd #17

Updates for the latest k8s and etcd #17

Conversation

tas50 commented Sep 5, 2017

aespinosa commented Sep 6, 2017

tas50 commented Sep 6, 2017

tas50 commented Sep 21, 2017

tas50 commented Sep 21, 2017

tas50 commented Sep 22, 2017

aespinosa left a comment

Choose a reason for hiding this comment

aespinosa Sep 22, 2017

Choose a reason for hiding this comment

aespinosa Sep 22, 2017

Choose a reason for hiding this comment

aespinosa commented Sep 23, 2017

tas50 commented Sep 23, 2017