🐛 Fix menu localization: site.Menus URLs are already localized #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
It appears that a website having a custom base URL generate invalid menu links using this template.
The reason is a computation of localization using
absLangURL
oversite.Menus
->.URL
items.In recent versions of Hugo, the
site.Menus
items are already localized. You can see in the official example here, there is noabsLangURL
declared after.URL
: https://gohugo.io/templates/menu/#exampleabsLangURL
should be used to convert a relative URL to a localized URL in case the URL is not localized yet. Calling a already-localized URL withabsLangURL
will append the language code twice. The problem may be not visible without declaring a custom baseURL because Hugo seems to automatically strip duplicated localization codes for ease.Was the change discussed in an issue or in the Discussions before?
I have not seen any issue about that, feel free to point it out if I missed it.
PR Checklist