Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix CSS/JS URLs reference to support deployment in a subdirectory #1622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

npellegrin
Copy link

@npellegrin npellegrin commented Oct 21, 2024

What does this PR change? What problem does it solve?

When deploying a Hugo website in a subdirectory of a domain instead of the root, we usually add --baseURL at compilation time, or add the parameter baseURL in config file. However, this behavior is not properly taken into account in this template for loading CSS and Javascript files, causing the stylesheet loading to fail in all pages.

Supporting the deployment in a subdirectory require to care about absolute URLs for all assets. This PR adds the | absURL instruction for CSS and JS loadded in header.html.

Was the change discussed in an issue or in the Discussions before?

I could not find an issue related to it, but feel free to point it out if I missed it :)

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant