Adopting README, documentation and import comments

Fixed an import grouping in kubeseal, fixed some typos in README and an erroneous revert (changed TPR -> CRD).
adevhammer · Apr 26, 2019 · 84e7325 · 84e7325
1 parent 5637f5b
commit 84e7325
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -130,21 +130,21 @@ labelled as active.
 #### Key rotation
 
 Keys are automatically rotated. This can be configured on startup with
-the `--rotate-preiod=<value>` flag. `value` is taken as milliseconds with
+the `--rotate-period=<value>` flag. `value` is taken as milliseconds with
 a default of 30 days.
 
 A key can be generated early in two ways
 1. Send `SIGUSR1` to the controller
 `kubectl exec -it <controller pod> -- kill -SIGUSR1 1`
-2. Label the current latest key as compromised (anything no active)
-`kubectl label secrets <keyname> sealed-secrets-key=compromised`
+2. Label the current latest key as compromised (any value other than active)
+`kubectl label secrets <keyname> sealed-secrets-key=compromised`.
 
-**NOTE** Sealed secrets currently does not automtically pick up
-relabelled keys, you must restart the controller before the effect
+**NOTE** Sealed secrets currently does not automatically pick up
+relabelled keys, an admin must restart the controller before the effect
 will apply.
 
 Labelling a secret with anything other than `active` effectively deletes
-the key from the sealed secrets controller, but it is still available for
+the key from the sealed secrets controller, but it is still available in k8s for
 manual encryption/decryption if need be.
 
 ## Developing

diff --git a/cmd/kubeseal/main.go b/cmd/kubeseal/main.go
@@ -12,13 +12,12 @@ import (
 	"os"
 	"strings"
 
-	"k8s.io/apimachinery/pkg/util/net"
-
 	flag "github.com/spf13/pflag"
 	"k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer"
+	"k8s.io/apimachinery/pkg/util/net"
 	"k8s.io/client-go/kubernetes/scheme"
 	corev1 "k8s.io/client-go/kubernetes/typed/core/v1"
 	"k8s.io/client-go/tools/clientcmd"

diff --git a/pkg/apis/sealed-secrets/v1alpha1/types.go b/pkg/apis/sealed-secrets/v1alpha1/types.go
@@ -6,7 +6,7 @@ import (
 )
 
 const (
-	// SealedSecretName is the name used in SealedSecret TPR
+	// SealedSecretName is the name used in SealedSecret CRD
 	SealedSecretName = "sealed-secret." + GroupName
 	// SealedSecretPlural is the collection plural used with SealedSecret API
 	SealedSecretPlural = "sealedsecrets"