Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type in READ.me example #5

Open
Bbeluco opened this issue Oct 9, 2023 · 0 comments
Open

Wrong type in READ.me example #5

Bbeluco opened this issue Oct 9, 2023 · 0 comments

Comments

@Bbeluco
Copy link

Bbeluco commented Oct 9, 2023

Hi, I was studying your project to practice my front-end skills and I notice some inconsistency on READ.me part (more specifically in Types section). As you can see in the prints, the MarketType is using markets as type instead selections.

I tried to open one PR fixing this point but i don't have access push updates to the repository. Here below i'll let the correct type and prints that show the error on my console. I got the json from the file data.json available in the test.

Wish you all the bests

Fixed version:
type EventType = {
id: string;
name: string;
markets: MarketType[];
};

/** Market Entity */
type MarketType = {
id: string;
name: string;
selections: SelectionType[];
}

/** Selection Entity */
type SelectionType = {
id: string;
name: string;
price: number;
}

Evidence:
Screenshot from 2023-10-09 19-57-07
Screenshot from 2023-10-09 19-57-16
Screenshot from 2023-10-09 19-57-31
Screenshot from 2023-10-09 19-57-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant