Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React HotgraphicPopup error #331

Closed
danielghost opened this issue Nov 18, 2024 · 1 comment · Fixed by #332
Closed

React HotgraphicPopup error #331

danielghost opened this issue Nov 18, 2024 · 1 comment · Fixed by #332
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

danielghost commented Nov 18, 2024 •
edited
Loading

#328 introduced the following error when an item is clicked:

Warning: Received `false` for a non-boolean attribute `id`.

If you want to write it to the DOM, pass a string instead: id="false" or id={value.toString()}.

If you used to conditionally omit it with id={condition && value}, pass id={condition ? value : undefined} instead. Error Component Stack

This is resolved by following the error instructions with:

id={_isActive ? 'notify-heading': undefined}
@danielghost danielghost self-assigned this Nov 18, 2024
danielghost added a commit that referenced this issue Nov 18, 2024
@danielghost
Fix: React HotgraphicPopup error fro conditional id attribute (fixes …
d4b3d5a 
…#331).
@danielghost danielghost mentioned this issue Nov 18, 2024
Merged
@danielghost danielghost moved this from New to Needs Reviewing in adapt_framework: The TODO Board Nov 18, 2024
joe-allen-89 pushed a commit that referenced this issue Nov 20, 2024
@danielghost
Fix: React HotgraphicPopup error for conditional id attribute (fixes …
0aeef85 
…#332)

* Fix: React HotgraphicPopup error fro conditional `id` attribute (fixes #331).

* Fixed eslint issue.
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 20, 2024
github-actions bot pushed a commit that referenced this issue Nov 20, 2024
@semantic-release-bot
Chore(release): 6.15.2 [skip ci]
1dbfc87 
## [6.15.2](v6.15.1...v6.15.2) (2024-11-20)

### Fix

* React HotgraphicPopup error for conditional `id` attribute (fixes #332) ([0aeef85](0aeef85)), closes [#332](#332) [#331](#331)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@danielghost danielghost mentioned this issue Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: React HotgraphicPopup error for conditional id attribute adaptlearning/adapt-contrib-hotgraphic
1 participant
@danielghost