Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: _type added to config.model.schema (fixes #614) #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: _type added to config.model.schema (fixes #614) #615

wants to merge 1 commit into from
+4 −0

Conversation

joe-allen-89
Copy link
Contributor

#614

Fix

@joe-allen-89 joe-allen-89 added the bug Something isn't working label Jan 16, 2025
@joe-allen-89 joe-allen-89 self-assigned this Jan 16, 2025
@joe-allen-89 joe-allen-89 linked an issue Jan 16, 2025 that may be closed by this pull request
_type missing from config.model.schema #614
Open
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member

None of the other schemas seem to have a _type attribute, except the newer config.json schema.

I imagine the AATs automatically add a hardcoded _type to the output?

Will including _type in the schema cause it to be editable in the AAT user interface?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug Something isn't working
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_type missing from config.model.schema
3 participants
@joe-allen-89 @oliverfoster @cahirodoherty-learningpool