Add Nordea Norway bank to the 90-days sync limited list #525
Conversation
actual-github-bot
bot
changed the title
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
dakipro
changed the title
my bank Nordea Norway (NORDEA_NDEANOKK) only supports 90 days of historical data, so per instructions I added it to the bank-factory.js file. p.s. I suspect Nordea in all countries does so as I see Danish is already on the list, but I know only of Nordea Norway
WalkthroughThe pull request introduces a modification to the Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)src/app-gocardless/bank-factory.js (1)
This addition aligns perfectly with the stated PR objective of restricting Nordea Norway’s transaction history to 90 days. To confirm there's no mismatch or accidental discrepancies, let’s verify that all references (if any) are spelled consistently: ✅ Verification successfulNORDEA_NDEANOKK is correctly added to the banks with limited history list The verification confirms that 'NORDEA_NDEANOKK' has been properly added to the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for references to NORDEA_NDEANOKK in the codebase to ensure consistency.
rg 'NORDEA_NDEANOKK'
Length of output: 76 Script: #!/bin/bash
# Let's verify the context of NORDEA_NDEANOKK in bank-factory.js
rg -B5 -A5 'NORDEA_NDEANOKK' src/app-gocardless/bank-factory.js
Length of output: 312 Script: #!/bin/bash
# Let's check the broader context to confirm this is within the 90-day sync limited list
rg -B20 -A5 '90.*day.*sync.*limit' src/app-gocardless/bank-factory.js
Length of output: 71 Script: #!/bin/bash
# Let's try a different approach to find the context where NORDEA_NDEANOKK is being used
# Looking for any array or list declaration containing this bank
ast-grep --pattern 'const $_ = [
$$$
'\''NORDEA_NDEANOKK'\'',
$$$
]'
Length of output: 3233 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi! Thanks for this, you'll need to add a release note before I can merge it in. https://actualbudget.com/docs/contributing/#writing-good-release-notes |
category: Enhancements
authors: [dakipro]
Add Nordea Norway bank to the 90-days sync limited list