Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for windows issues #528

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Fixes for windows issues #528

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5701cf1
fixes windows issues
AbhinavTuli Feb 3, 2021
7a0030e
cleanup
AbhinavTuli Feb 3, 2021
d11b061
adds tests for other environments
AbhinavTuli Feb 4, 2021
daa6a4b
reverting circleci config
AbhinavTuli Feb 4, 2021
911185d
fixing test due to wasabi issue
AbhinavTuli Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixing test due to wasabi issue
  • Loading branch information
@AbhinavTuli
AbhinavTuli committed Feb 4, 2021
commit 911185d1a42f7d55978225cbab5fe274907d9bf5
4 changes: 2 additions & 2 deletions hub/api/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,8 @@ def test_dataset_batch_write_2():
def test_dataset_hub():
password = os.getenv("ACTIVELOOP_HUB_PASSWORD")
login_fn("testingacc", password)
test_dataset("testingacc/test_dataset_private", public=False)
test_dataset("testingacc/test_dataset_public")
test_dataset("testingacc/test_dataset_private_2", public=False)
test_dataset("testingacc/test_dataset_public_2")


@pytest.mark.skipif(not gcp_creds_exist(), reason="requires gcp credentials")
Expand Down