Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds.extend speedup #2328

Merged
merged 1 commit into from
May 3, 2023
Merged

ds.extend speedup #2328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deeplake/core/dataset/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2623,8 +2623,9 @@ def extend(self, samples: Dict[str, Any], skip_ok: bool = False):
f"Incoming samples are not of equal lengths. Incoming sample sizes: {sizes}"
)
[f() for f in list(self._update_hooks.values())]
for i in range(n):
self.append({k: v[i] for k, v in samples.items()}, skip_ok=skip_ok)
with self:
for i in range(n):
self.append({k: v[i] for k, v in samples.items()}, skip_ok=skip_ok)

@invalid_view_op
def append(
Expand Down