Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lists and modifiers #310

Merged
merged 88 commits into from
Apr 8, 2021
Merged

Improve lists and modifiers #310

merged 88 commits into from
Apr 8, 2021

Conversation

rokasramas
Copy link
Member

@rokasramas rokasramas commented Mar 31, 2021 •
edited
Loading

  • Lists:
    • Updated available list categories: "CN", "NP", "AP", "Adv", "IAdv", "AdV", "RS", "S"
    • Fixed various issues
  • Modifiers:
    • Better support for "Punct", "Subj", "Voc" and "Conj" modifiers
  • Added missing category for dictionary items from quick search menu

rokasramas added 30 commits March 16, 2021 11:10
@rokasramas
chore: ignore stats
2addfb9
@rokasramas
refactor: extend dictionary item schema
6d47047
@rokasramas
fix: attribute values are read incorrectly
9186327
@rokasramas
feat: find intersection when encountering ambiguous categories
b335511
@rokasramas
refactor: better handling of types when role categories are ambiguous
38df124
@rokasramas
refactor: better handling of optional arg categories
c4b6b5b
@rokasramas
fix: document plan category resolution
6a45724
@rokasramas
refactor: enable providing document plan description
e1087e1
@rokasramas
refactor: verify document plan examples
dd1573b
@rokasramas
chore: update lacinia version in deps to prevent warning
99a896f
@rokasramas
Merge branch 'extend-dictionary-item-schema' of github.com:tokenmill/…
f0ac5b0 
…accelerated-text into improve-generate-efficiency
@rokasramas
test: complex amr generation
88b31e3
@rokasramas
Merge branch 'master' of github.com:tokenmill/accelerated-text into i…
956360e 
…mprove-generate-efficiency
@rokasramas
refactor: do not add paragraph symbol node if there is only one segment
66f640f
@rokasramas
refactor: amr graph building
849e3ed
@rokasramas
chore: remove graph display
b46d4db
@rokasramas
fix: amr graph building errors
b648f7c
@rokasramas
fix: null pointer exception when amr role category is not defined
7074ebc
@rokasramas
refactor: attribute access
168e1da
@rokasramas
fix: remove amr category
337a5d1
@rokasramas
refactor: use map insteaf of pmap
aa2126c
@rokasramas
refactor: change result request log level to debug
e2a092a
@rokasramas
chore: restore log level
008b172
@rokasramas
fix: ordering of segments when adding paragraph symbol
86fbecd
@rokasramas
chore: fix lint warnings
9e9d5a4
@rokasramas
refactor: dict and doc plan init
85980ba
@rokasramas
refactor: disable flags by default
dc22d3f
@rokasramas
refactor: add default language to dict items
115abdc
@rokasramas
chore: prevent gf warnings of conflict
d98de9e
@rokasramas
feat: deduplicate results
3ae7a9f
@codecov-io
Copy link

codecov-io commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #310 (9298501) into master (ad3b112) will increase coverage by 0.37%.
The diff coverage is 70.23%.

❗ Current head 9298501 differs from pull request most recent head 4e07847. Consider uploading reports for the commit 4e07847 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   72.70%   73.07%   +0.37%     
==========================================
  Files          90       91       +1     
  Lines        4231     4342     +111     
  Branches      205      210       +5     
==========================================
+ Hits         3076     3173      +97     
- Misses        950      959       +9     
- Partials      205      210       +5
Flag Coverage Δ
api 66.06% <58.57%> (-0.05%) ⬇️
core 80.28% <78.57%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/api/config.clj 15.00% <0.00%> (ø)
api/src/api/server.clj 76.34% <ø> (+1.60%) ⬆️
api/src/data/entities/data_files.clj 83.96% <0.00%> (-2.58%) ⬇️
api/src/data/entities/document_plan.clj 53.84% <0.00%> (-8.66%) ⬇️
api/src/api/graphql/translate/dictionary.clj 79.31% <37.50%> (-6.69%) ⬇️
api/src/data/entities/dictionary.clj 68.96% <50.00%> (-0.68%) ⬇️
core/src/acc_text/nlg/graph/dictionary.clj 50.00% <50.00%> (ø)
core/src/acc_text/nlg/graph/modifier.clj 75.22% <72.30%> (+5.48%) ⬆️
api/src/api/graphql/translate/document_plan.clj 82.14% <79.54%> (-17.86%) ⬇️
api/src/api/nlg/parser.clj 70.02% <100.00%> (+0.23%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3b112...4e07847. Read the comment docs.

@rokasramas rokasramas changed the title Improve lists Improve lists and modifiers Apr 1, 2021
rokasramas added 18 commits April 1, 2021 19:14
@rokasramas rokasramas merged commit 8a24b3d into master Apr 8, 2021
@rokasramas rokasramas deleted the improve-lists branch July 21, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokasramas @codecov-io