From b6b9481b7b11f5ef6b3c5f866483cfdbcace97a3 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 10 Aug 2022 11:42:34 +0530 Subject: [PATCH] fix(DX): make warnings go to stderr --- bench/utils/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bench/utils/__init__.py b/bench/utils/__init__.py index 010ae94b6..ff8f8fcdb 100644 --- a/bench/utils/__init__.py +++ b/bench/utils/__init__.py @@ -79,7 +79,7 @@ def is_valid_frappe_branch(frappe_path: str, frappe_branch: str): raise InvalidRemoteException(f"Invalid frappe path: {frappe_path}") from e -def log(message, level=0, no_log=False): +def log(message, level=0, no_log=False, stderr=False): import bench import bench.cli @@ -96,13 +96,13 @@ def log(message, level=0, no_log=False): bench.LOG_BUFFER.append({"prefix": prefix, "message": message, "color": color}) if no_log: - click.secho(message, fg=color) + click.secho(message, fg=color, err=stderr) else: loggers = {2: logger.error, 3: logger.warning} level_logger = loggers.get(level, logger.info) level_logger(message) - click.secho(f"{prefix}: {message}", fg=color) + click.secho(f"{prefix}: {message}", fg=color, err=stderr) def check_latest_version(): @@ -125,7 +125,7 @@ def check_latest_version(): local_version = Version(VERSION) if pypi_version > local_version: - log(f"A newer version of bench is available: {local_version} → {pypi_version}") + log(f"A newer version of bench is available: {local_version} → {pypi_version}", stderr=True) def pause_exec(seconds=10):