Skip to content

Commit

Permalink
Phantom shim mention (puppeteer#552)
Browse files Browse the repository at this point in the history
Remote remaining mentions of PhantomShim
  • Loading branch information
JoelEinbinder authored and aslushnikov committed Aug 25, 2017
1 parent e8f8a1a commit bd5b4fe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ HEADLESS=false SLOW_MO=500 npm run unit
npm run debug-unit
```

There are also phantomjs tests located under [third_party/phantomjs/test](https://github.com/GoogleChrome/puppeteer/tree/master/third_party/phantomjs). These
are used to test `phantom_shim`.

## Public API Coverage

Every public API method or event should be called at least once in tests. To ensure this, there's a coverage command which tracks calls to public API and reports back if some methods/events were not called.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"unit": "jasmine test/test.js",
"debug-unit": "DEBUG_TEST=true node --inspect-brk ./node_modules/.bin/jasmine test/test.js",
"test-doclint": "jasmine utils/doclint/check_public_api/test/test.js && jasmine utils/doclint/preprocessor/test.js",
"test": "npm run lint --silent && npm run coverage && npm run test-phantom && npm run test-doclint && npm run test-node6",
"test": "npm run lint --silent && npm run coverage && npm run test-doclint && npm run test-node6",
"install": "node install.js",
"lint": "([ \"$CI\" = true ] && eslint --quiet -f codeframe . || eslint .) && npm run doc",
"doc": "node utils/doclint/cli.js",
Expand Down

0 comments on commit bd5b4fe

Please sign in to comment.