Ruby 3.2 compatibility ✅ #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing bug with class invoker, maybe we can use method(:x).parameters to know what kind of parameters does it have) Added a new test for class with keyword arguments
…on instead of relying on arity
|
Code Climate has analyzed commit 231f2fa and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the invoker classes, we started to rely on
.parametersto know if there are keyword arguments. It's a clearer approach than relying on arity. I couldn't make it work by just relying on arity.I've also improved test coverage a bit, those new test cases were all failing because of the Ruby 3.2 upgrade, so the new tests were added because of that.