Fix current event through fire #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilmaurya
reviewed
Jul 16, 2019
| describe "when calling events with fire/fire!" do | ||
| it "fire should populate aasm.current_event" do | ||
| pe.aasm.fire(:wakeup) | ||
| expect(pe.aasm.current_event).to eq :wakeup |
There was a problem hiding this comment.
Can you add assertion for transition as well?
DoubleJarvis
force-pushed
the
fix_current_event_through_fire
branch
from
2bb992b to
cf75bdb
Compare
|
Code Climate has analyzed commit cf75bdb and detected 0 issues on this pull request. View more on Code Climate. |
|
Are the tests in cf75bdb satisfactory, or you mean something else by transition? @anilmaurya |
|
@DoubleJarvis Tests looks good 👍. Thank you for contributing. Tests are failing on travis for some other reason. First I will fix travis build then I will merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #551. It already has a PR that should fix it, but it has duplicate logic, and its just lying there for a year, unmerged, and the issue is still present.