Fix checkstyle errors in collections library

aaronkim · Sep 20, 2016 · cb8ed9a · cb8ed9a
1 parent c384d94
commit cb8ed9a
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 13 deletions.
diff --git a/java/libs/src/main/java/org/physical_web/collection/EddystoneBeacon.java b/java/libs/src/main/java/org/physical_web/collection/EddystoneBeacon.java
@@ -23,6 +23,10 @@
 import java.util.HashMap;
 import java.util.UUID;
 
+/**
+ * Eddystone beacon class.
+ * This class represents the Eddystone broadcasting format.
+ */
 public class EddystoneBeacon {
   private static final byte URL_FRAME_TYPE = 0x10;
   private static final byte TITLE_TYPE = 0x0e;
@@ -65,7 +69,7 @@ private EddystoneBeacon(byte flags, byte txPower, String url) {
   }
 
   /**
-   * Reads the title of a fat beacon broadcast
+   * Reads the title of a fat beacon broadcast.
    * @param serviceData The ble advertised Eddystone URL Service UUID service data
    * @return Title encoded in the broadcast
    */
@@ -78,7 +82,7 @@ public static String getFatBeaconTitle(byte[] serviceData) {
   }
 
   /**
-   * Checks if the broadcast is a fat beacon
+   * Checks if the broadcast is a fat beacon.
    * @param serviceData The ble advertised Eddystone URL Service UUID service data
    * @return true if it is a fat beacon, false otherwise
    */
@@ -88,7 +92,7 @@ public static boolean isFatBeacon(byte[] serviceData) {
   }
 
   /**
-   * Checks if the broadcast is a Eddystone URL
+   * Checks if the broadcast is a Eddystone URL.
    * @param serviceData The ble advertised Eddystone URL Service UUID service data
    * @return true if it is a URL, false otherwise
    */
@@ -169,23 +173,23 @@ private static String decodeUrnUuid(byte[] serviceData, StringBuilder urnBuilder
 
 
   /**
-   * Getter for the Eddystone URL
+   * Getter for the Eddystone URL.
    * @return Eddystone URL
    */
   public String getUrl() {
     return mUrl;
   }
 
   /**
-   * Getter for the Tx Power Level
+   * Getter for the Tx Power Level.
    * @return Tx Power Level
    */
   public byte getTxPowerLevel() {
     return mTxPower;
   }
 
   /**
-   * Getter for the flags
+   * Getter for the flags.
    * @return flags
    */
   public byte getFlags() {

diff --git a/java/libs/src/main/java/org/physical_web/collection/PhysicalWebCollection.java b/java/libs/src/main/java/org/physical_web/collection/PhysicalWebCollection.java
@@ -72,8 +72,8 @@ public boolean addUrlDevice(UrlDevice urlDevice) {
     mDeviceIdToUrlDeviceMap.put(urlDevice.getId(), urlDevice);
     return alreadyFound;
   }
-  
-  /** 
+
+  /**
    * Remove a UrlDevice from the collection.
    * @param urlDevice The UrlDevice to remove.
    */

diff --git a/java/libs/src/test/java/org/physical_web/collection/EddystoneBeaconTest.java b/java/libs/src/test/java/org/physical_web/collection/EddystoneBeaconTest.java
@@ -17,9 +17,11 @@
 
 import static org.junit.Assert.*;
 
-import org.junit.Before;
 import org.junit.Test;
 
+/**
+ * Tests for the EddystoneBeacon class.
+ */
 public class EddystoneBeaconTest {
 
   @Test

diff --git a/java/libs/src/test/java/org/physical_web/collection/PhysicalWebCollectionTest.java b/java/libs/src/test/java/org/physical_web/collection/PhysicalWebCollectionTest.java
@@ -22,11 +22,11 @@
 import org.junit.Before;
 import org.junit.Test;
 
+import org.skyscreamer.jsonassert.JSONAssert;
+
 import java.util.Comparator;
 import java.util.List;
 
-import org.skyscreamer.jsonassert.JSONAssert;
-
 /**
  * PhysicalWebCollection unit test class.
  */

diff --git a/java/libs/src/test/java/org/physical_web/collection/UrlGroupTest.java b/java/libs/src/test/java/org/physical_web/collection/UrlGroupTest.java
@@ -17,11 +17,11 @@
 
 import static org.junit.Assert.*;
 
-import java.util.Comparator;
-
 import org.junit.Before;
 import org.junit.Test;
 
+import java.util.Comparator;
+
 /**
  * UrlGroup unit test class.
  */