Declared non-seekable streams as non-seekable in callback input (#648)

Declared non-seekable streams as non-seekable in callback input Increased the buffer size to match VLC buffer size Related to #647
ZeBobo5 · May 22, 2020 · 6b3bfc7 · 6b3bfc7
1 parent 2f28a71
commit 6b3bfc7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 - ADDED support for .net core 3.0 for Vlc.DotNet.Forms and Vlc.DotNet.Wpf
 - DROPPED support for .net framework 2.0
 - FIXED race conditions on Dispose() [#641](https://github.com/ZeBobo5/Vlc.DotNet/pull/641). Fixes [#639](https://github.com/ZeBobo5/Vlc.DotNet/issues/639) and [#640](https://github.com/ZeBobo5/Vlc.DotNet/issues/640)
+- FIXED Media created from non-seekable .NET Streams were declared as seekable for libvlc [#648](https://github.com/ZeBobo5/Vlc.DotNet/pull/648). See [#647](https://github.com/ZeBobo5/Vlc.DotNet/issues/647).
+- CHANGED The buffer size for media created from .NET Streams from 16kiB to 16MiB. It takes more memory, but allows to read more data at once. [#648](https://github.com/ZeBobo5/Vlc.DotNet/pull/648)
 
 # 3.0.0
 - BREAKING CHANGE : Created a new WPF control using ImageSource [#365](https://github.com/ZeBobo5/Vlc.DotNet/pull/365) see how to use in wiki!

diff --git a/src/Vlc.DotNet.Core.Interops/VlcManager.CreateNewMediaFromStream.cs b/src/Vlc.DotNet.Core.Interops/VlcManager.CreateNewMediaFromStream.cs
@@ -44,7 +44,7 @@ public VlcMediaInstance CreateNewMediaFromStream(Stream stream)
                 myVlcInstance,
                 CallbackOpenMediaDelegate,
                 CallbackReadMediaDelegate,
-                CallbackSeekMediaDelegate,
+                stream.CanSeek ? CallbackSeekMediaDelegate : null,
                 CallbackCloseMediaDelegate,
                 opaque
                 ));
@@ -148,7 +148,7 @@ private static IntPtr AddStream(Stream stream)
                 handle = new IntPtr(streamIndex);
                 DicStreams[handle] = new StreamData()
                 {
-                    Buffer = new byte[0x4000],
+                    Buffer = new byte[0x100_0000],
                     Handle = handle,
                     Stream = stream
                 };