Prefer using TimeSpan.FromMilliseconds rather than multiplying by 10000

Using the TimeChanged event rather than PositionChanged to display current time in WinForms sample
ZeBobo5 · Oct 14, 2018 · 57e3ec3 · 57e3ec3
1 parent 12e28de
commit 57e3ec3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/Samples/Samples.WinForms.Advanced/Sample.Designer.cs b/src/Samples/Samples.WinForms.Advanced/Sample.Designer.cs
diff --git a/src/Samples/Samples.WinForms.Advanced/Sample.cs b/src/Samples/Samples.WinForms.Advanced/Sample.cs
@@ -60,13 +60,12 @@ private void OnButtonPauseClicked(object sender, EventArgs e)
 
         private void OnVlcMediaLengthChanged(object sender, VlcMediaPlayerLengthChangedEventArgs e)
         {
-            myLblMediaLength.InvokeIfRequired(l => l.Text = new DateTime(new TimeSpan(e.NewLength).Ticks).ToString("T"));
+            myLblMediaLength.InvokeIfRequired(l => l.Text = TimeSpan.FromMilliseconds(e.NewLength).ToString(@"hh\:mm\:ss"));
         }
 
-        private void OnVlcPositionChanged(object sender, VlcMediaPlayerPositionChangedEventArgs e)
+        private void OnVlcTimeChanged(object sender, VlcMediaPlayerTimeChangedEventArgs e)
         {
-            var position = myVlcControl.GetCurrentMedia().Duration.Ticks * e.NewPosition;
-            myLblVlcPosition.InvokeIfRequired(l => l.Text = new DateTime((long)position).ToString("T"));
+            myLblVlcPosition.InvokeIfRequired(l => l.Text = TimeSpan.FromMilliseconds(e.NewTime).ToString(@"hh\:mm\:ss"));
         }
 
         private void OnVlcPaused(object sender, VlcMediaPlayerPausedEventArgs e)

diff --git a/src/Vlc.DotNet.Core/VlcMedia/VlcMedia.cs b/src/Vlc.DotNet.Core/VlcMedia/VlcMedia.cs
@@ -77,7 +77,7 @@ public MediaStates State
 
         public TimeSpan Duration
         {
-            get { return new TimeSpan(myVlcMediaPlayer.Manager.GetMediaDuration(MediaInstance) * 10000); }
+            get { return TimeSpan.FromMilliseconds(myVlcMediaPlayer.Manager.GetMediaDuration(MediaInstance)); }
         }
 
         public void Dispose()