Skip to content

Commit

Permalink
[bazel] Clean up unused exported files (#114620)
Browse files Browse the repository at this point in the history
Some minor cleanup to the bazel files. These exported files are not
being referenced anymore in the tree, afaict, so let's clean them up.
Additionally, moved one of the filegroup targets higher to be consistent
with other filegroup usages where it's defined before first usage.
  • Loading branch information
thevinster authored Nov 4, 2024
1 parent fa57c7a commit bb9ff32
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 22 deletions.
8 changes: 0 additions & 8 deletions utils/bazel/llvm-project-overlay/clang/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ package(

licenses(["notice"])

exports_files([
"tools/clang-format/clang-format.el",
"tools/clang-format/clang-format-test.el",
"tools/clang-format/clang-format.py",
"tools/extra/clang-include-fixer/tool/clang-include-fixer.el",
"tools/extra/clang-include-fixer/tool/clang-include-fixer-test.el",
])

cc_binary(
name = "clang-tblgen",
srcs = glob([
Expand Down
26 changes: 12 additions & 14 deletions utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ licenses(["notice"])
exports_files([
"LICENSE.TXT",
"cmake/modules/llvm-driver-template.cpp.in",
"include/llvm/BinaryFormat/Dwarf.def",
"include/llvm/CodeGen/SDNodeProperties.td",
"include/llvm/CodeGen/ValueTypes.td",
"include/llvm/Frontend/Directive/DirectiveBase.td",
Expand All @@ -32,7 +31,6 @@ exports_files([
"include/llvm/IR/Intrinsics.td",
"include/llvm/Option/OptParser.td",
"utils/lit/lit.py",
"utils/lldbDataFormatters.py",
])

# It may be tempting to add compiler flags here, but that should be avoided.
Expand Down Expand Up @@ -1248,6 +1246,18 @@ cc_library(
],
)

filegroup(
name = "common_target_td_sources",
srcs = glob([
"include/llvm/CodeGen/*.td",
"include/llvm/Frontend/Directive/*.td",
"include/llvm/IR/Intrinsics*.td",
"include/llvm/TableGen/*.td",
"include/llvm/Target/*.td",
"include/llvm/Target/GlobalISel/*.td",
]),
)

gentbl(
name = "ARMTargetParserDefGen",
tbl_outs = [("-gen-arm-target-def", "include/llvm/TargetParser/ARMTargetParserDef.inc")],
Expand Down Expand Up @@ -2325,18 +2335,6 @@ cc_library(
textual_hdrs = ["lib/Target/X86/X86InstrInfo.h"],
)

filegroup(
name = "common_target_td_sources",
srcs = glob([
"include/llvm/CodeGen/*.td",
"include/llvm/Frontend/Directive/*.td",
"include/llvm/IR/Intrinsics*.td",
"include/llvm/TableGen/*.td",
"include/llvm/Target/*.td",
"include/llvm/Target/GlobalISel/*.td",
]),
)

gentbl(
name = "amdgpu_isel_target_gen",
strip_include_prefix = "lib/Target/AMDGPU",
Expand Down

0 comments on commit bb9ff32

Please sign in to comment.