Skip to content

Commit

Permalink
(re-)Autogen one last unroll-and-jam test
Browse files Browse the repository at this point in the history
This case was complicated because someone had added new non-autogened test to an autogened file.  In particular, those new tests used two variables (%J and %j) which differeded only in capitalization.  The auto-updater doesn't distinguish case, so this meant auto-gened versions of the new tests failed with non-obvious errors.

There are two key lessons here:
1) Please don't use two values which differ only in case.  This is problematic for automatic tooling, but is also hard to understand for a human.
2) Please DO NOT add new tests to an autogened test without running autogen again.  If autogen doesn't pass on your new test, put them in a separate file.
  • Loading branch information
preames committed Nov 12, 2021
1 parent d1b09ad commit a1b496b
Showing 1 changed file with 963 additions and 207 deletions.
Loading

0 comments on commit a1b496b

Please sign in to comment.