Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Sentence length and paragraph length to use HTML parser and enable AI button for both assessments #21866

Open
wants to merge 16 commits into
base: trunk
Choose a base branch
from
+698 −640
Open

Convert Sentence length and paragraph length to use HTML parser and enable AI button for both assessments #21866

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0eb3bab
Converts the sentence length assessment to use the HTML Parser
mhkuu Nov 12, 2024
684baab
Adds a temporary output script and (a currently failing) unit test
mhkuu Nov 13, 2024
e338b83
First pass on converting the paragraph length assessment to use the H…
mhkuu Nov 14, 2024
151132e
Enable AI button for SentenceLengthInTextAssessment.js and ParagraphT…
FAMarfuaty Nov 27, 2024
7ca0e32
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into html-pars…
FAMarfuaty Nov 27, 2024
a30b72d
Return assessmentResult
FAMarfuaty Nov 27, 2024
4b9349c
Adapt getMarks for ParagraphTooLongAssessment.js
FAMarfuaty Nov 27, 2024
db4877e
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into html-pars…
mhkuu Dec 10, 2024
500e2cb
Fix highlighting for paragraph length assessment
FAMarfuaty Dec 11, 2024
9289968
Improve JSDoc
FAMarfuaty Dec 11, 2024
65ec1ae
Remove unused import
FAMarfuaty Dec 16, 2024
fd3ed61
Adds processing of hyphens
mhkuu Dec 16, 2024
78b00fc
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into html-pars…
FAMarfuaty Dec 18, 2024
95ece64
Adapt fullTexttest
FAMarfuaty Dec 18, 2024
e8e1c16
Adjust unit tests
FAMarfuaty Dec 18, 2024
322b221
Fix typos
FAMarfuaty Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust unit tests
  • Loading branch information
@FAMarfuaty
FAMarfuaty committed Dec 18, 2024
commit e8e1c16e9f80d594ce079e1a41f713c8b2e2a3eb
60 changes: 9 additions & 51 deletions packages/yoastseo/spec/languageProcessing/researches/getParagraphLengthSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,47 +26,15 @@ describe( "a test for getting paragraph length", function() {
} );

it( "returns the paragraph length of two paragraphs divided by double linebreaks and ends with a double linebreak", function() {
// After using the HTML parser, we don't split paragraphs on double linebreaks, so this should be one paragraph.
const mockPaper = new Paper( "Lorem \n\n ipsum two \n\n" );
const mockResearcher = new EnglishResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 1 );
expect( paragraphLengths[ 1 ].paragraphLength ).toBe( 2 );
} );

it( "returns the paragraph length of two paragraphs in Japanese divided by double linebreaks and ends with a double linebreak", function() {
const mockPaper = new Paper( "1964年 \n\n （昭和39年） \n\n" );
const mockResearcher = new JapaneseResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 5 );
expect( paragraphLengths[ 1 ].paragraphLength ).toBe( 7 );
} );

it( "returns the paragraph length of two paragraphs divided by double linebreaks that don't end with a double linebreak", function() {
const mockPaper = new Paper( "Lorem \n\n ipsum two" );
const mockResearcher = new EnglishResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 1 );
expect( paragraphLengths[ 1 ].paragraphLength ).toBe( 2 );
} );

it( "returns the paragraph length of two paragraphs in Japanese divided by double linebreaks that don't end with a double linebreak", function() {
const mockPaper = new Paper( "1964年 \n\n （昭和39年）" );
const mockResearcher = new JapaneseResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 5 );
expect( paragraphLengths[ 1 ].paragraphLength ).toBe( 7 );
expect( paragraphLengths.length ).toBe( 1 );
expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 3 );
} );

it( "returns the paragraph length of a paragraph without tags or double linebreaks", function() {
Expand Down Expand Up @@ -162,44 +130,34 @@ describe( "a test for getting paragraph length", function() {
expect( paragraphLengths.length ).toBe( 1 );
} );

it( "returns the paragraph length of paragraph without p tags or double linebreaks, but with h2 tags", function() {
it( "should not recognize heading as paragraph", function() {
const mockPaper = new Paper( "<h2>Lorem ipsum dolor sit amet</h2>" );
const mockResearcher = new EnglishResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 5 );
} );

it( "returns the paragraph length of paragraph in Japanese without p tags or double linebreaks, but with h2 tags", function() {
const mockPaper = new Paper( "<h2>（昭和39年）10月1日に開業した。</h2>" );
const mockResearcher = new JapaneseResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths[ 0 ].paragraphLength ).toBe( 18 );
expect( paragraphLengths.length ).toBe( 0 );
} );

xit( "returns the paragraph length of an empty paragraph with p tags", function() {
it( "should not count an empty paragraph", function() {
const mockPaper = new Paper( "<p></p>" );
const mockResearcher = new EnglishResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths.paragraphLength ).not.toContain( 0 );
expect( paragraphLengths.length ).toBe( 0 );
} );

xit( "returns the paragraph length of an empty paragraph without p tags or double line breaks", function() {
it( "should not count an empty paragraph without p tags or double line breaks", function() {
const mockPaper = new Paper( "" );
const mockResearcher = new EnglishResearcher( mockPaper );
buildTree( mockPaper, mockResearcher );

const paragraphLengths = getParagraphLength( mockPaper, mockResearcher );

expect( paragraphLengths.paragraphLength ).not.toContain( 0 );
expect( paragraphLengths.length ).toBe( 0 );
} );
} );

Expand Down
Loading