-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Sentence length and paragraph length to use HTML parser and enable AI button for both assessments #21866
Open
FAMarfuaty
wants to merge
16
commits into
trunk
Choose a base branch
from
html-parser/paragraph-length
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+698
−640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FAMarfuaty
changed the title
Html parser/paragraph length
Convert Sentence length and paragraph length to use HTML parser and enable AI button for both assessments
Nov 27, 2024
…ooLongAssessment.js
…er/paragraph-length
…er/paragraph-length
18 tasks
FAMarfuaty
added
the
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
label
Dec 17, 2024
…er/paragraph-length
FAMarfuaty
added
innovation
Innovative issue. Relating to performance, memory or data-flow.
Shopify
This PR impacts Shopify.
labels
Dec 18, 2024
mhkuu
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Looks great, nice to see all this simplified code 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
innovation
Innovative issue. Relating to performance, memory or data-flow.
Shopify
This PR impacts Shopify.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Optimize AI button in Free
for sentence length and paragraph length assessments
For the scenarios below, also install and activate Yoast SEO Premium. If building the plugin, pair this PR with this PR in Premium: https://github.com/Yoast/wordpress-seo-premium/pull/4527
Paragraph length assessment
Sentence length assessment
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/lingo-other-tasks/issues/114
Fixes https://github.com/Yoast/lingo-other-tasks/issues/471
Fixes https://github.com/Yoast/wordpress-seo-premium/issues/4524