Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include metadata in the API endpoints #21861

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Include metadata in the API endpoints #21861

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7da1cda
Add metadata in the results and refactor score classes accordingly
leonidasmi Nov 25, 2024
0ba229a
Return array of results from the collector
leonidasmi Nov 25, 2024
79d15c0
Return current scores in the expected order
leonidasmi Nov 25, 2024
7187e51
Merge feature branch
leonidasmi Nov 25, 2024
ae2ac97
Rename scores to score groups for better readability
leonidasmi Nov 26, 2024
03b699f
Rename collector method to reflect getting score results
leonidasmi Nov 26, 2024
01c04e3
Dont add link if it's null
leonidasmi Nov 26, 2024
4aadc27
Update the frontend with the new response structure
leonidasmi Nov 26, 2024
3d06b3f
Clean up
leonidasmi Nov 26, 2024
6ad6444
Refactor by creating a separate repository for current scores
leonidasmi Nov 26, 2024
a94b9db
Fix for PHP 8.2
leonidasmi Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix for PHP 8.2
  • Loading branch information
@leonidasmi
leonidasmi committed Nov 26, 2024
commit a94b9db5b8d81ed63d0238df88de81999954ab99
7 changes: 7 additions & 0 deletions src/dashboard/application/score-results/abstract-score-results-repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ abstract class Abstract_Score_Results_Repository {
*/
protected $score_results_collector;

/**
* The current scores repository.
*
* @var Current_Scores_Repository
*/
protected $current_scores_repository;

/**
* All score groups.
*
Expand Down