Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

192 wc editor create two way sync for the post metadata #21398

Draft
wants to merge 12 commits into
base: feature/woo-new-editor
Choose a base branch
from
Draft

192 wc editor create two way sync for the post metadata #21398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
85f983b
Add createCollectorFromObject
igorschoester Apr 9, 2024
e64c914
Add shared constants
igorschoester Apr 9, 2024
9583e9f
Use new editor store constant
igorschoester Apr 9, 2024
08c9fe6
Add default metadata the script data
igorschoester Apr 25, 2024
946d255
Extend the default editor store
igorschoester Apr 25, 2024
9946418
Add sync from and to metadata
igorschoester Apr 25, 2024
e413a1a
Fix side-effects to not error
igorschoester Apr 25, 2024
68f6c13
Fix defaults for advanced settings
igorschoester Apr 25, 2024
bfd8efe
Add selector for the social image ids
igorschoester Apr 25, 2024
4ddf221
Fix postId initial state
igorschoester Apr 25, 2024
2f21ab8
Add safety to the primary taxonomies selector
igorschoester Apr 25, 2024
7ba27f7
Add overall score selectors for the analyses
igorschoester Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add selector for the social image ids 
* possibly the fallbacks for the IDs should be -1 instead
* fix the facebook url fallback to return an empty string
  • Loading branch information
@igorschoester
igorschoester committed Apr 25, 2024
commit bfd8efea9b1e89ecc1bb8c760199d7fca2d0caf7
11 changes: 10 additions & 1 deletion packages/js/src/redux/selectors/facebookEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,23 @@ export const getFacebookTitle = state => get( state, "facebookEditor.title", ""
*/
export const getFacebookDescription = state => get( state, "facebookEditor.description", "" );

/**
* Gets the facebook image ID from the state.
*
* @param {Object} state The state.
*
* @returns {?number} Facebook image ID.
*/
export const getFacebookImageId = state => get( state, "facebookEditor.image.id", null );

/**
* Gets the facebook image URL from the state.
*
* @param {Object} state The state.
*
* @returns {String} Facebook image URL.
*/
export const getFacebookImageUrl = state => get( state, "facebookEditor.image.url" );
export const getFacebookImageUrl = state => get( state, "facebookEditor.image.url", "" );

/**
* Gets the facebook image src from the state.
Expand Down
9 changes: 9 additions & 0 deletions packages/js/src/redux/selectors/twitterEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ export const getTwitterDescription = state => get( state, "twitterEditor.descrip
*/
export const getTwitterImageUrl = state => get( state, "twitterEditor.image.url", "" );

/**
* Gets the twitter image ID from the state.
*
* @param {Object} state The state.
*
* @returns {?number} Twitter image ID.
*/
export const getTwitterImageId = state => get( state, "twitterEditor.image.id", null );

/**
* Gets the twitter image type from the state.
*
Expand Down