Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple primary term second round #21361

Open
wants to merge 35 commits into
base: feature/decouple-hidden-fields
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
32ec6ec
remove the addition to the hidden fields
vraja-pro May 2, 2024
adcc654
remove the saving of the primary term
vraja-pro May 2, 2024
3436ab1
remove the register meta of primary terms
vraja-pro May 2, 2024
fc9d316
add primary term to general fields for meta register and render of hi…
vraja-pro May 2, 2024
b27ed0b
fix array type annotation
vraja-pro May 2, 2024
546211a
register all taxonomies primary terms
vraja-pro May 2, 2024
dc7e955
Add primary terms to hidden fields
vraja-pro May 2, 2024
92d356e
fix test
vraja-pro May 2, 2024
3857c7b
php fix cs
vraja-pro May 2, 2024
0442376
we accept id as integer
vraja-pro May 2, 2024
dffdf50
fix threshold and restore type
vraja-pro May 2, 2024
79717fe
moved the primary term sanitisation from wpseo meta
vraja-pro May 2, 2024
8c8e7fd
Update src/initializers/primary-term-metadata.php
vraja-pro May 8, 2024
3e72ab2
Update src/integrations/watchers/primary-term-watcher.php
vraja-pro May 8, 2024
429c25f
register primary terms when they are registered
vraja-pro May 8, 2024
9fd3bca
php fix-cs
vraja-pro May 9, 2024
ec38db2
fix integration tests
vraja-pro May 9, 2024
b6d96b4
cleanup and rename registering of primary term meta
vraja-pro May 9, 2024
20e8eeb
fix registering primary term meta
vraja-pro May 14, 2024
ba841a6
Merge branch 'feature/decouple-hidden-fields' into decouple-primary-t…
vraja-pro May 23, 2024
08280fc
fix annotation and warnings
vraja-pro May 23, 2024
3dd3cb5
fix php cs
vraja-pro May 23, 2024
6bc6c7b
remove registration of primary terms to initializer class
vraja-pro May 27, 2024
4d9e2a9
fixed primary term initial state
vraja-pro May 27, 2024
d66595b
restore sanitisation of primary terms in wpseo meta class
vraja-pro May 27, 2024
9cf8eb9
used the new registered field in the block editor sync
vraja-pro May 27, 2024
50b806e
php fix cs
vraja-pro May 27, 2024
0b39ab4
cleanup of primary term admin class
vraja-pro May 27, 2024
1846695
eslint fix cs
vraja-pro May 27, 2024
7e41d5b
add tests to primary term metadata class
vraja-pro May 27, 2024
6fe438c
eslint fix cs
vraja-pro May 27, 2024
5ec6738
restore saving hidden fields
vraja-pro May 27, 2024
0ad1824
restore register meta
vraja-pro May 27, 2024
8e937cd
restore initial value
vraja-pro May 27, 2024
c2a5535
update thresholds
vraja-pro May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove the register meta of primary terms
  • Loading branch information
vraja-pro committed May 14, 2024
commit 3436ab1bf66d121742001a6664c317691f0f71bb
13 changes: 0 additions & 13 deletions inc/class-wpseo-meta.php
Original file line number Diff line number Diff line change
Expand Up @@ -302,19 +302,6 @@ public static function init() {
}
unset( $extra_fields );

// register meta data for taxonomies.
self::$meta_fields['primary_terms'] = [];

$taxonomies = get_taxonomies( [ 'hierarchical' => true ], 'names' );
foreach ( $taxonomies as $taxonomy_name ) {
self::$meta_fields['primary_terms'][ 'primary_' . $taxonomy_name ] = [
'type' => 'hidden',
'title' => '',
'default_value' => '',
'description' => '',
];
}

foreach ( self::$meta_fields as $subset => $field_group ) {
foreach ( $field_group as $key => $field_def ) {

Expand Down