-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indexable visibility columns #17757
Open
diedexx
wants to merge
58
commits into
trunk
Choose a base branch
from
FIX-22-number-of-posts
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
b3fd2cd
Ensure array return type
diedexx 87c11c3
Allow for deprecating columns
diedexx 2eef6e2
Add method for creating a noindex query for indexables
diedexx b5bc8db
Rename is_public to is_publicly_viewable and number_of_public_posts t…
diedexx 6c015ba
Use PHP 5.6 syntax
diedexx 3d96968
Add migrations
diedexx acdf97a
Deprecate is_public instead of immediately replacing it
diedexx e18c9ac
Keep the method name the same and deprecate
diedexx 58d6a71
Access properties that were renamed earlier
diedexx b7cfa04
Make the homepage get a number_of_publicly_viewable_posts and is_publ…
diedexx c2d121e
Use new column name
diedexx 38b552d
Add deprecation tags
diedexx 2fdce2f
Fix cs
diedexx 3a18f72
Mark enabled date archives as publicly viewable
diedexx 5e89640
Delegate logic to central helper
diedexx 0a38f49
Make global namespace usage explicit
diedexx 81e7421
Flip argument order
diedexx 1564f53
Allow for considering empty archives as indexed
diedexx ecae28e
Update deperatation based on the expected release version
diedexx ea0a46e
Prevent new integrators from accessing is_public
diedexx 6ccacd5
Update tests
diedexx ccf7f9b
Remove resolved todo comment
diedexx af7b219
Rebuild date archive indexable when disabling date archives
diedexx 510f9de
Fix cs
diedexx ed46abb
Prevent deprecation warnings when (re)indexing
diedexx ff247f9
Include password protected posts in aggegrate queries
diedexx ca85a07
Keep the most recent last modified date.
diedexx faf1180
Merge branch 'trunk' of https://github.com/Yoast/wordpress-seo into F…
diedexx f6a8adf
Adhere to naming conventions
diedexx 274df53
Don't hardcode the deprecation version number
diedexx d51829e
Update deprecation versions and descriptions
diedexx 5c1193a
Rename migration
diedexx 661e9a3
Merge branch 'trunk' of https://github.com/Yoast/wordpress-seo into F…
diedexx 82f8a78
Fix cs
diedexx 66d6e4d
Update tests
diedexx cf56df4
Fill WP 5.7 function
diedexx 68aba31
Mock calls to newly introduced functions
diedexx 3329a1b
Polyfill WP 5.7 function
diedexx e906ace
Lower error threshold
diedexx 29739ee
Remove unused function that never made it into trunk
diedexx 66c9433
Remove test double funtion that was removed in its parent
diedexx 9eb9263
Make global namespace explicit
diedexx 0c9ac1a
Ensure that post_types is an array
diedexx 2059186
Automatically update date-archive indexables
diedexx b95492e
Use the type of the originally requested property in case of replaced…
diedexx 101edcf
Merge branch 'trunk' of https://github.com/Yoast/wordpress-seo into F…
diedexx 5d095a5
Fix CS warnings and errors
diedexx d8f754f
Fix tests
diedexx f613dfc
Clarify that the comment is about a function
diedexx 3e7e755
Add instructions to remove related code
diedexx c24488e
Reduce risk of using the same builder version twice.
diedexx 4ed8b38
Update post relation indexables when a post is set to private
diedexx 275c423
Fix cs
diedexx 08c1f5f
Fix precedence issues in query
diedexx e1c5055
Merge branch 'trunk' of https://github.com/Yoast/wordpress-seo into F…
diedexx 6cf15bf
Increase threhshold
diedexx bad2929
Exclude password protected posts from the publicly_viewable_count
diedexx 148d47c
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into FIX-22-nu…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Ensure array return type
This caused issues with the rename_column, as column_info expects an array
- Loading branch information
commit b3fd2cd266504945441c4233e7e821a35d007963
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that
select_one()
is only used atcolumn_info()
which is turn is used only atrename_column()
which is not actively used anywhere in our org.