Fix trace context propagation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same as in test & production.
This is technically a breaking change, but since it's a change in APM itself, there's nothing we can do to avoid it.
Prior to this commit, the `start-transaction` function used the value of the `:traceparent` option as the value of every trace context header, including `tracestate`. As a result, clojure-elastic-apm did not propagate e.g. the sample rate configured in the upstream system to downstream systems.
AriPaaWun
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Korjataan trace context headereiden propagoituminen alavirtaan. Edellinen versio asetti
:traceparent-avaimen arvon kaikkien trace context headereiden arvoksi (ml.tracestate). Tämä estitracestate:n arvon propagoitumisen kutsuvasta järjestelmästä alavirran järjestelmiin.Päivitetään samalla riippuvuudet ja korjataan epäyhteensopivuus ELK 8.x:n kanssa (merkkijono on ainoa sallittu tyyppi labeleiden arvolle).