Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

新增skip_exit参数，控制退出流程 #96

Closed
Yikun opened this issue Mar 11, 2021 · 3 comments
Closed

新增skip_exit参数，控制退出流程 #96

Yikun opened this issue Mar 11, 2021 · 3 comments
Labels
priority/wishlist

Comments

@Yikun
Copy link
Owner

Yikun commented Mar 11, 2021

在 #62 讨论的时候，我们发现了一个潜在需求。

目前实现，如果有failed_list，会直接以exit code 1退出，最终导致任务失败。

这样可能会影响到后续其他流程的job，所以，如果一个用户需要在hub-mirror-action同步失败的情况下，job也不退出的话，那么可以新增一个参数来控制。

  • 默认，skip_exit为false时，job会根据同步情况进行退出。
  • skip_exit为true时，job永远会成功。

不过这个需求，我觉得应该是写workflow的人控制的，我猜github action本身应该有个什么参数也可以在workflow控制一下？
@yi-Xu-0100
Copy link
Contributor

@Yikun actions 中有一定的检查状态的表达式。见 https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#job-status-check-functions

@Yikun
Copy link
Owner Author

Yikun commented Mar 11, 2021

Yep，就是这个，那我觉得这个需求优先级就更低啦，没什么没必要了~

@Yikun
Copy link
Owner Author

Yikun commented Apr 9, 2022 •
edited
Loading

这个问题关了，我觉得目前的方式可能更好，尽力同步所有repo，如果失败在end退出并且print失败的仓库。

如果后续还有job不想受到action job的影响，可以用strategy.fail-fast去控制，也可以用if: ${{ always() }}控制后续流程。

@Yikun Yikun closed this as completed Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/wishlist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yikun @yi-Xu-0100