Fixed bug causing http status of last event to not get reported.

XDelphiGrl · Jul 20, 2012 · 2f1fc49 · 2f1fc49
1 parent 6f92b13
commit 2f1fc49
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/com/lazerycode/selenium/filedownloader/FileDownloader.java b/src/main/java/com/lazerycode/selenium/filedownloader/FileDownloader.java
@@ -43,7 +43,7 @@ public class FileDownloader {
     private String localDownloadPath = System.getProperty("java.io.tmpdir");
     private boolean followRedirects = true;
     private boolean mimicWebDriverCookieState = true;
-    private int httpStatusOfLastDownloadAttempt;
+    private int httpStatusOfLastDownloadAttempt = 0;
 
     public FileDownloader(WebDriver driverObject) {
         this.driver = driverObject;
@@ -103,7 +103,7 @@ public String downloadImage(WebElement element) throws Exception {
      *
      * @return
      */
-    public int httpStatusOfLastDownloadAttempt() {
+    public int getHTTPStatusOfLastDownloadAttempt() {
         return this.httpStatusOfLastDownloadAttempt;
     }
 
@@ -169,7 +169,8 @@ private String downloader(WebElement element, String attribute) throws IOExcepti
 
         LOG.info("Sending GET request for: " + httpget.getURI());
         HttpResponse response = client.execute(httpget, localContext);
-        LOG.info("HTTP GET request status: " + response.getStatusLine().getStatusCode());
+        this.httpStatusOfLastDownloadAttempt = response.getStatusLine().getStatusCode();
+        LOG.info("HTTP GET request status: " + this.httpStatusOfLastDownloadAttempt);
         LOG.info("Downloading file: " + downloadedFile.getName());
         FileUtils.copyInputStreamToFile(response.getEntity().getContent(), downloadedFile);
         response.getEntity().getContent().close();

diff --git a/src/test/java/com/lazerycode/selenium/filedownloader/FileDownloaderTest.java b/src/test/java/com/lazerycode/selenium/filedownloader/FileDownloaderTest.java
@@ -63,6 +63,7 @@ public void downloadAFile() throws Exception {
         String downloadedFileAbsoluteLocation = downloadTestFile.downloadFile(downloadLink);
 
         assertThat(new File(downloadedFileAbsoluteLocation).exists(), is(equalTo(true)));
+        assertThat(downloadTestFile.getHTTPStatusOfLastDownloadAttempt(), is(equalTo(200)));
     }
 
     @Test
@@ -73,5 +74,6 @@ public void downloadAnImage() throws Exception {
         String downloadedImageAbsoluteLocation = downloadTestFile.downloadImage(image);
 
         assertThat(new File(downloadedImageAbsoluteLocation).exists(), is(equalTo(true)));
+        assertThat(downloadTestFile.getHTTPStatusOfLastDownloadAttempt(), is(equalTo(200)));
     }
 }