Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate usage of empty() construct #1803

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Eliminate usage of empty() construct #1803

wants to merge 5 commits into from

Conversation

ShyamGadde
Copy link
Contributor

Summary

Fixes #1219

Relevant technical choices

This PR eliminates the use of empty() in the following plugins:

  • dominant-color-images
  • performance-lab
  • webp-uploads

@ShyamGadde
Eliminate usage of empty construct in dominant-color-images plugin
f6a89b1 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@ShyamGadde
Eliminate usage of empty construct in performance-lab plugin
7e480ca 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@ShyamGadde
Fix incorrect parameter name in documentation for apply_filters function
50a6d78 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@ShyamGadde
Eliminate usage of empty construct in webp-uploads plugin
70e55e4 
Signed-off-by: Shyamsundar Gadde <shyamsundar.gadde@rtcamp.com>
@ShyamGadde ShyamGadde added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jan 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.90698% with 19 lines in your changes missing coverage. Please review.

Project coverage is 57.51%. Comparing base (abbdd78) to head (9a85740).
Report is 71 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/webp-uploads/hooks.php 72.34% 13 Missing ⚠️
plugins/webp-uploads/deprecated.php 0.00% 5 Missing ⚠️
plugins/dominant-color-images/hooks.php 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #1803      +/-   ##
==========================================
+ Coverage   57.41%   57.51%   +0.10%     
==========================================
  Files          84       84              
  Lines        6521     6560      +39     
==========================================
+ Hits         3744     3773      +29     
- Misses       2777     2787      +10
Flag Coverage Δ
multisite 57.51% <77.90%> (+0.10%) ⬆️
single 34.72% <76.74%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShyamGadde ShyamGadde removed [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein will be requested when the pull request is marked ready for review adamsilverstein is a code owner

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz will be requested when the pull request is marked ready for review felixarntz is a code owner

@westonruter westonruter Awaiting requested review from westonruter westonruter will be requested when the pull request is marked ready for review westonruter is a code owner

@pbearne pbearne Awaiting requested review from pbearne pbearne will be requested when the pull request is marked ready for review pbearne is a code owner

@manuelRod manuelRod Awaiting requested review from manuelRod manuelRod will be requested when the pull request is marked ready for review manuelRod is a code owner

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27 mukeshpanchal27 will be requested when the pull request is marked ready for review mukeshpanchal27 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checks to disallow use of empty()
1 participant
@ShyamGadde