Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Allow style prop on Popover #64489

Merged
merged 9 commits into from
Aug 15, 2024
Merged

Components: Allow style prop on Popover #64489

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19a3316
Allow style prop on popover
talldan Aug 13, 2024
a1e6790
Ensure styles are not overwritten by popoverProps
talldan Aug 14, 2024
88e256d
Add tests and fix overriding of built-in popover styles
talldan Aug 14, 2024
f16689b
Update comment
talldan Aug 14, 2024
ca16f8b
Remove blank line
talldan Aug 14, 2024
1517db0
Un-should tests
talldan Aug 14, 2024
adcbf5e
Update test to use `not.toHaveStyle
talldan Aug 14, 2024
c6b4e8c
Add changelog entry
talldan Aug 14, 2024
c811da6
Remove `style` from types file
talldan Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add changelog entry
  • Loading branch information
@talldan
talldan committed Aug 14, 2024
commit c6b4e8ce5ef82f0adfdff412f3fa96d5e774187b
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
- `Composite`: improve Storybook examples and add interactive controls ([#64397](https://github.com/WordPress/gutenberg/pull/64397)).
- `TimePicker`: add `hideLabelFromVision` prop ([#64267](https://github.com/WordPress/gutenberg/pull/64267)).
- `DropdownMenuV2`: adopt elevation scale ([#64432](https://github.com/WordPress/gutenberg/pull/64432)).
- `Popover`: allow `style` prop usage ([#64489](https://github.com/WordPress/gutenberg/pull/64489)).


## 28.5.0 (2024-08-07)

Expand Down
Loading