-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Editor: Revert "Save" button to "Update" #63399
base: trunk
Are you sure you want to change the base?
Post Editor: Revert "Save" button to "Update" #63399
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @rohitmathur-7, @james-tyner. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rohitmathur-7! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hey Thanks for the PR. I understand that in some situations it may be less clear but I think there are pros and cons. "Update" doesn't work well in multiple situations:
And Save is more generic and just means save all the changes, so it works in more situations I would say. |
Thank you for the PR! I've commented on the issue and now saw your PR, so I'll drop a link here too. My comment:
So, since this PR tries to fix the use case of the linked issue, If I'm right, there shouldn't be any confusion because the update/save change doesn't apply. Finally, I'd echo Riad about |
Hello! I created the linked issue #63387 that led to this PR. I understand the argument that Save is generic enough to apply in all situations, but I think the key issue here isn't what the button is doing, but what the state of the button is representing to the user. Users have likely grown accustomed to seeing an "Update" button and recognizing that to mean that the post is published. At a publication where multiple writers and editors may jump in and out of posts and reach them directly from outside the context of the Posts list in WordPress (which shows the post status), it's important for people to have an easy way to know what the status is from the post editor screen. If we are opposed to moving away from the generic "Save" wording, it would be valuable to devote some effort to other ways of keeping users aware of the status of the post. I saw on #60456 that there was some design effort going into creating a color-coded post status label that would appear at the top of the settings sidebar, and I think that would help a lot. My proposal is that we could try to preserve the Update button for now until those other status indicators are ready. |
I want to note as well that the "save" label also existed before if you were using the site editor instead. In 6.6 the post and site editor UIs are unified which led to the user of the more generic "save" label. So there will be a change for users regardless of which label is picked. I'd appreciate more design eyes on this but I have a feeling that "save" is less confusing in more situations than "update". |
What?
Revert "Save" button to "Update", and "Saving..." to "Updating..." in the post editor.
Issue: #63387
Why?
Save word is a little confusing to users when they are actually updating the post.
How?
Replaced "Save" word with "Update" and, replaced "Saving..." with "Updating...".
Testing Instructions
Screenshots or screencast