Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor: Revert "Save" button to "Update" #63399

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

rohitmathur-7
Copy link
Contributor

What?

Revert "Save" button to "Update", and "Saving..." to "Updating..." in the post editor.
Issue: #63387

Why?

Save word is a little confusing to users when they are actually updating the post.

How?

Replaced "Save" word with "Update" and, replaced "Saving..." with "Updating...".

Testing Instructions

  • Go to the Post editor.
  • Make changes in the post.
  • We can see the button on top with the word "Update".

Screenshots or screencast

gutenberg-post-editor-btn

Copy link

github-actions bot commented Jul 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @rohitmathur-7, @james-tyner.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: rohitmathur-7, james-tyner.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 11, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rohitmathur-7! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@youknowriad
Copy link
Contributor

Hey Thanks for the PR. I understand that in some situations it may be less clear but I think there are pros and cons.

"Update" doesn't work well in multiple situations:

  • When you're saving multiple entities (not just a single post)
  • When you're switching the status back to "draft", I'm not sure if "update" is correct. Save is better.

And Save is more generic and just means save all the changes, so it works in more situations I would say.

@ntsekouras
Copy link
Contributor

Thank you for the PR! I've commented on the issue and now saw your PR, so I'll drop a link here too.

My comment:

Thanks for the issue! I think you're mostly referring to a possible accidental publishing of a draft. In that case the button doesn't render 'Saveinstead ofUpdate, but it renders Publish`, which was also the case before the saving/publishing flow updates. Did I get that wrong here?

Additionally, all these changes have made the current status value of the editing post more prominent, in the post summary(inspector controls), which IMO it also reduce the risk of not knowing the post status.

So, since this PR tries to fix the use case of the linked issue, If I'm right, there shouldn't be any confusion because the update/save change doesn't apply.

Finally, I'd echo Riad about save being more generic than update.

@james-tyner
Copy link

Hello! I created the linked issue #63387 that led to this PR.

I understand the argument that Save is generic enough to apply in all situations, but I think the key issue here isn't what the button is doing, but what the state of the button is representing to the user. Users have likely grown accustomed to seeing an "Update" button and recognizing that to mean that the post is published.

At a publication where multiple writers and editors may jump in and out of posts and reach them directly from outside the context of the Posts list in WordPress (which shows the post status), it's important for people to have an easy way to know what the status is from the post editor screen.

If we are opposed to moving away from the generic "Save" wording, it would be valuable to devote some effort to other ways of keeping users aware of the status of the post. I saw on #60456 that there was some design effort going into creating a color-coded post status label that would appear at the top of the settings sidebar, and I think that would help a lot.

My proposal is that we could try to preserve the Update button for now until those other status indicators are ready.

@youknowriad
Copy link
Contributor

I want to note as well that the "save" label also existed before if you were using the site editor instead. In 6.6 the post and site editor UIs are unified which led to the user of the more generic "save" label. So there will be a change for users regardless of which label is picked.

I'd appreciate more design eyes on this but I have a feeling that "save" is less confusing in more situations than "update".

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants