Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Block Editor Settings Endpoint - Update to return resolved values #54215

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

[Mobile] Block Editor Settings Endpoint - Update to return resolved values #54215

wants to merge 5 commits into from

Conversation

geriux
Copy link
Member

@geriux geriux commented Sep 6, 2023 •
edited
Loading

In progress...

What?

This is a follow-up to the recent changes in #50484. It adds an option to return global style values already resolved, omitting the CSS variables.

Why?

We currently parse CSS values manually every time the mobile editor is opened. This creates additional load, particularly on slower devices. Retrieving the resolved values will expedite editor loading times.

How?

Parameters have been added to gutenberg_get_global_styles to return the resolved values.

Additionally, gutenbergVersion has been introduced. This is crucial for feature synchronization with the user's current Gutenberg plugin, especially given the slow update rollouts for mobile apps. This will help prevent breakages in unsupported features.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Gerardo added 2 commits September 6, 2023 12:14
Experimental - Block editor settings mobile - Update __experimentalSt…
4c8b070 
…yles to return transformed values
Experimental - Block editor settings mobile - Return the Gutenberg pl…
8aa0af9 
…ugin version for feature compatibility and deprecations
@geriux geriux added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Feature New feature to highlight in changelogs. labels Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/block-editor-settings-mobile.php
❔ lib/experimental/class-wp-rest-block-editor-settings-controller.php
❔ lib/load.php

@geriux geriux added the REST API Interaction Related to REST API label Sep 6, 2023
@geriux geriux mentioned this pull request Sep 6, 2023
Draft
@geriux
Copy link
Member Author

geriux commented Sep 27, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

This endpoint still under the experimental folder and it does not need to be synced to Core.

@github-actions
Copy link

Flaky tests detected in 947dac2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6326125744
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs TimothyBJacobs will be requested when the pull request is marked ready for review TimothyBJacobs is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey will be requested when the pull request is marked ready for review spacedmonkey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) REST API Interaction Related to REST API [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geriux