test: skip integration test configure_peers_update_only on FreeBSD

Signed-off-by: Steffen Vogel <post@steffenvogel.de>
WireGuard · mdlayher · Nov 4, 2022 · Oct 9, 2022 · Oct 9, 2022 · Oct 10, 2022
commit 846054fa57c4fac96c9063e8723a139e5d3c55b5
diff --git a/client_integration_test.go b/client_integration_test.go
@@ -365,6 +365,12 @@ func testConfigurePeersUpdateOnly(t *testing.T, c *wgctrl.Client, d *wgtypes.Dev
 	}
 
 	if err := c.ConfigureDevice(d.Name, cfg); err != nil {
+		if d.Type == wgtypes.FreeBSDKernel && err == wgtypes.ErrUpdateOnlyNotSupported {
+			// TODO(stv0g): remove as soon as the FreeBSD kernel module supports it
+			t.Skip("FreeBSD kernel devices do not support UpdateOnly flag")
+		}
+
+
 		t.Fatalf("failed to configure second time on %q: %v", d.Name, err)
 	}
 

diff --git a/internal/wgfreebsd/client_freebsd.go b/internal/wgfreebsd/client_freebsd.go
@@ -166,6 +166,20 @@ func (c *Client) Device(name string) (*wgtypes.Device, error) {
 
 // ConfigureDevice implements wginternal.Client.
 func (c *Client) ConfigureDevice(name string, cfg wgtypes.Config) error {
+	// Check if there is a peer with the UpdateOnly flag set.
+	// This is not supported on FreeBSD yet. So error out..
+	// TODO(stv0g): remove this check once kernel support has landed.
+	for _, peer := range cfg.Peers {
+		if peer.UpdateOnly {
+			// Check that this device is really an existing kernel
+			// device
+			if _, err := c.Device(name); err != os.ErrNotExist {
+				return wgtypes.ErrUpdateOnlyNotSupported
+			}
+		}
+	}
+
+
 	m := unparseConfig(cfg)
 	mem, sz, err := nv.Marshal(m)
 	if err != nil {

diff --git a/wgtypes/errors.go b/wgtypes/errors.go
@@ -0,0 +1,10 @@
+package wgtypes
+
+import (
+	"errors"
+)
+
+// ErrUpdateOnlyNotSupported is returned due to missing kernel support of
+// the PeerConfig UpdateOnly flag.
+var ErrUpdateOnlyNotSupported = errors.New("the UpdateOnly flag is not supported by this platform")
+