Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection API: Upgrade GeoTrellis #61

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Aug 8, 2017

Overview

Upgrades GeoTrellis to latest in the api project. The summary project continues to use the old one for compatibility reasons.

Connects #49

Testing Instructions

  • Run server and test :8090/ping and :8090/run endpoints
  • Run cibuild and ensure the JAR builds successfully

The summary project continues to use the old one for compatibility
reasons.
Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Tested this and the server & jar versions both work.

@kellyi kellyi assigned rajadain and unassigned kellyi Aug 8, 2017
"com.azavea.geotrellis" %% "geotrellis-spark" % Version.geotrellis,
"com.azavea.geotrellis" %% "geotrellis-s3" % Version.geotrellis,
"com.azavea.geotrellis" %% "geotrellis-spark" % Version.geotrellisOld,
"com.azavea.geotrellis" %% "geotrellis-s3" % Version.geotrellisOld,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we can use both GT versions simultaneously. I guess that's a benefit of having a multi-project build.

@rajadain
Copy link
Member Author

rajadain commented Aug 8, 2017

I thought about also upgrading to build.sbt, but found the documentation a little dense, so I'm leaving it up to #57. Thanks for taking a look, your initial setup made this very easy to do.

@rajadain
Copy link
Member Author

rajadain commented Aug 8, 2017

I just added another commit to demo that the import actually works. Could you please give this another try?

@kellyi
Copy link
Contributor

kellyi commented Aug 8, 2017

Sure!

@kellyi
Copy link
Contributor

kellyi commented Aug 8, 2017

Rebuilt the jar and everything still works! 👍

@rajadain rajadain merged commit a554418 into develop Aug 8, 2017
@rajadain rajadain deleted the tt/upgrade-geotrellis branch August 8, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants