Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st1303: add more natural format encoding support #266

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Apr 18, 2021

Motivation and Context

We have most of what we need from ST 1303 (array encoding) for MIMD and ST 1206, but coverage isn't too good on other aspects, especially on 1D signed integer, and some other natural format encoding. I'm working down the list in preparation for future MIMD and some of the lesser-used formats which potentially need this.

Relates to #198, but doesn't complete it.

Description

Adds encoding for:

  • 1D signed integer in natural format
  • 2D unsigned integer in natural format
  • 2D boolean in natural format

Adds decoding for:

  • 1D signed integer in natural format

Fixes some minor issues and test naming in existing code.

How Has This Been Tested?

Re-ran unit tests as part of full build.

Screenshots (if appropriate):

N/A.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wlfgang wlfgang merged commit 8612306 into WestRidgeSystems:develop Apr 26, 2021
@bradh bradh deleted the st1303_2021-04-18 branch April 26, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants