Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed --alias from verify command. #867

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Removed --alias from verify command. #867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ecde76
Adjusted log message to clarify which SAID errored as SADs may contai…
daidoji Apr 25, 2024
0ddc90e
Adjusted workflow to get right image to run
daidoji Apr 26, 2024
65c8c0a
Adjusted help descriptions to more accurately describe what that comm…
daidoji Aug 7, 2024
ffe7eca
Restored these files to what they are in origin/main
daidoji Aug 7, 2024
9de937c
Merge branch 'main' of https://github.com/WebOfTrust/keripy
daidoji Aug 12, 2024
926f0d1
Merge branch 'main' of https://github.com/WebOfTrust/keripy
daidoji Sep 14, 2024
465b60b
Removed --prefix from verify command.
daidoji Sep 21, 2024
76f5159
Merge branch 'main' of https://github.com/WebOfTrust/keripy
daidoji Oct 8, 2024
56678a3
Merge branch 'main' of https://github.com/WebOfTrust/keripy
daidoji Nov 5, 2024
01c7cb2
Merge branch 'main' into remove-prefix-from-verify-command-2
daidoji Nov 5, 2024
47a9529
Reverted to remove alias rather than prefix from verify command
daidoji Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed --prefix from verify command. 
Prefixes are 1-1 with aliases which are already required for this
command and thus redundant.  Removed for ease of use.
  • Loading branch information
@daidoji
daidoji committed Sep 21, 2024
commit 465b60bc16f6ff513d02aad4f344d08a5634991d
8 changes: 4 additions & 4 deletions scripts/demo/basic/demo-script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,16 @@ isSuccess
kli sign --name test --base "${KERI_TEMP_DIR}" --alias trans --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json
isSuccess

kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --prefix EIryzWYlZ9bQr7EhMAoBXk4r2h-OgaEqERid7-AHNp6o --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature AABuQervAG8QLyvho99362U8TScec_4zYDVF1pUMWfWfKbl5thR6QakpvSvVMdcPcGYxi0McgNtW-Z3EhpC01I4A
kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature AABuQervAG8QLyvho99362U8TScec_4zYDVF1pUMWfWfKbl5thR6QakpvSvVMdcPcGYxi0McgNtW-Z3EhpC01I4A
isSuccess

kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --prefix EIryzWYlZ9bQr7EhMAoBXk4r2h-OgaEqERid7-AHNp6o --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ABBJcS2ZbcHEdEEnaJE1CFUxdsKqkoU5TS34CImGh3s0cs-k3cNcy2PJxQ8WjIvAot1-cZ71o1E-WkqZ-tCTNZsJ
kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ABBJcS2ZbcHEdEEnaJE1CFUxdsKqkoU5TS34CImGh3s0cs-k3cNcy2PJxQ8WjIvAot1-cZ71o1E-WkqZ-tCTNZsJ
isSuccess

kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --prefix EIryzWYlZ9bQr7EhMAoBXk4r2h-OgaEqERid7-AHNp6o --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ACBieMVQBXvIxeqQuHc4Db_-GUoFE9e37TW8t6DomwXdMcSxBiHJpDp3EJH1Dcz9lHKbFuCRqoNo4wywZGtUpOcB
kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ACBieMVQBXvIxeqQuHc4Db_-GUoFE9e37TW8t6DomwXdMcSxBiHJpDp3EJH1Dcz9lHKbFuCRqoNo4wywZGtUpOcB
isSuccess

kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --prefix EIryzWYlZ9bQr7EhMAoBXk4r2h-OgaEqERid7-AHNp6o --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ACSHdal6kHAAjbW_frH83sDDCoBHw_nNKFysW5Dj8PSsnwVPePCNw-kFmF6Z8H87q7D3abw_5u2i4jmzdnWFsRDz
kli verify --name test --base "${KERI_TEMP_DIR}" --alias trans --text @${KERI_DEMO_SCRIPT_DIR}/data/anchor.json --signature ACSHdal6kHAAjbW_frH83sDDCoBHw_nNKFysW5Dj8PSsnwVPePCNw-kFmF6Z8H87q7D3abw_5u2i4jmzdnWFsRDz
ret=$?
if [ $ret -eq 0 ]; then
echo "Testing invalid signature should fail $ret"
Expand Down
4 changes: 1 addition & 3 deletions src/keri/app/cli/commands/verify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
parser.add_argument('--alias', '-a', help='human readable alias for the new identifier prefix', required=True)
parser.add_argument('--passcode', '-p', help='21 character encryption passcode for keystore (is not saved)',
dest="bran", default=None) # passcode => bran

parser.add_argument("--prefix", help="Identifier prefix of the signer", required=True)
parser.add_argument('--text', '-t', help='Original signed text or file (starts with "@")', required=True)
parser.add_argument('--signature', '-s', default=[], help='list of signatures to verify (can appear multiple times)',
action="append", required=True)
Expand Down Expand Up @@ -54,7 +52,7 @@ def verify(tymth, tock=0.0, **opts):
try:
with existing.existingHab(name=name, alias=alias, base=base, bran=bran) as (_, hab):

kever = hab.kevers[args.prefix]
kever = hab.kevers[hab.pre]

txt = args.text
if txt.startswith("@"):
Expand Down
2 changes: 0 additions & 2 deletions tests/app/cli/test_kli_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,6 @@ def test_standalone_kli_commands(helpers, capsys):
'ACCLl9pVv7OM4Y261GZkpPWQu__1mw8ffzcFY1lJ62CGjiEh3mvESu_N7a01YOCKqicqEe5TOXSf0j_8qBxPKxwO\n')

args = parser.parse_args(["verify", "--name", "test", "--alias", "trans",
"--prefix",
'EF0bnfg4smFm9Q_OKlKUYRRQctGhTBWUU3rXf7zuA9GU',
"--text",
"this is test data to sign",
"--signature",
Expand Down
Loading